[MJAVADOC-791] maven-javadoc-plugin not working correctly together with maven-toolchains-plugin

michael-o · michael-o · commit 3eb47c5081bf · 2024-07-13T23:10:05.000+02:00
This closes #299
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java b/src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
@@ -636,7 +636,9 @@ private void executeClirr() throws MavenInvocationException {
                 properties,
                 invokerLogFile,
                 session.getRequest().getGlobalSettingsFile(),
-                session.getRequest().getUserSettingsFile());
+                session.getRequest().getUserSettingsFile(),
+                session.getRequest().getGlobalToolchainsFile(),
+                session.getRequest().getUserToolchainsFile());
 
         try {
             if (invokerLogFile.exists()) {
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
@@ -5531,7 +5531,9 @@ private List<OfflineLink> getModulesLinks() throws MavenReportException {
                             null,
                             invokerLogFile,
                             session.getRequest().getGlobalSettingsFile(),
-                            session.getRequest().getUserSettingsFile());
+                            session.getRequest().getUserSettingsFile(),
+                            session.getRequest().getGlobalToolchainsFile(),
+                            session.getRequest().getUserToolchainsFile());
                 } catch (MavenInvocationException e) {
                     logError("MavenInvocationException: " + e.getMessage(), e);
 
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
@@ -715,6 +715,8 @@ protected static void copyResource(URL url, File file) throws IOException {
      * @param invokerLog the log file where the invoker will be written, if null using <code>System.out</code>.
      * @param globalSettingsFile reference to settings file, could be null.
      * @param userSettingsFile reference to user settings file, could be null.
+     * @param globalToolchainsFile reference to toolchains file, could be null.
+     * @param userToolchainsFile reference to user toolchains file, could be null.
      * @throws MavenInvocationException if any
      * @since 2.6
      */
@@ -726,7 +728,9 @@ protected static void invokeMaven(
             Properties properties,
             File invokerLog,
             File globalSettingsFile,
-            File userSettingsFile)
+            File userSettingsFile,
+            File globalToolchainsFile,
+            File userToolchainsFile)
             throws MavenInvocationException {
         if (projectFile == null) {
             throw new IllegalArgumentException("projectFile should be not null.");
@@ -763,6 +767,8 @@ protected static void invokeMaven(
         request.setPomFile(projectFile);
         request.setGlobalSettingsFile(globalSettingsFile);
         request.setUserSettingsFile(userSettingsFile);
+        request.setGlobalToolchainsFile(globalToolchainsFile);
+        request.setToolchainsFile(userToolchainsFile);
         request.setBatchMode(true);
         if (log != null) {
             request.setDebug(log.isDebugEnabled());
diff --git a/src/test/java/org/apache/maven/plugins/javadoc/FixJavadocMojoTest.java b/src/test/java/org/apache/maven/plugins/javadoc/FixJavadocMojoTest.java
@@ -547,6 +547,8 @@ private void invokeCompileGoal(File testPom, Log log) throws Exception {
                 properties,
                 invokerLogFile,
                 null,
+                null,
+                null,
                 null);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -547,6 +547,8 @@ private void invokeCompileGoal(File testPom, Log log) throws Exception {`
`547`	`547`	`properties,`
`548`	`548`	`invokerLogFile,`
`549`	`549`	`null,`
	`550`	`+ null,`
	`551`	`+ null,`
`550`	`552`	`null);`
`551`	`553`	`}`
`552`	`554`