Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINVOKER-296] Warn-log the case of incomplete name-description #97

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[MINVOKER-296] Warn-log the case of incomplete name-description #97

merged 1 commit into from
Feb 9, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Feb 2, 2022

No description provided.

@pzygielo pzygielo force-pushed the name-description-warning branch 2 times, most recently from d6c7cd2 to 2e1ebef Compare February 2, 2022 15:46
@slawekjaranowski
Copy link
Member

please create jira issue for it

@slawekjaranowski slawekjaranowski self-requested a review February 2, 2022 16:28
@pzygielo pzygielo changed the title Warn-log the case of incomplete name-description [MINVOKER-296] Warn-log the case of incomplete name-description Feb 2, 2022
@pzygielo pzygielo marked this pull request as ready for review February 2, 2022 16:42
@pzygielo pzygielo marked this pull request as draft February 2, 2022 17:10
@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 2, 2022

It's seems I'm not following my own description/intention from the JIRA. Have to check it.

@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 2, 2022

invoker-report IT has name has description warn for name warn for description
failure-build N N N N
failure-post N Y Y N
failure-pre Y N N Y
skip-jre N Y Y N
skip-maven N Y Y N
skip-os N Y Y N
success Y Y N N
expected warnings 4 1

@pzygielo pzygielo force-pushed the name-description-warning branch from a9ce77e to d0bfae0 Compare February 2, 2022 17:46
@slawekjaranowski
Copy link
Member

At the end please squash commits and add issue to commit subject

@pzygielo pzygielo force-pushed the name-description-warning branch from d0bfae0 to b6092a5 Compare February 2, 2022 18:11
@pzygielo
[MINVOKER-296] Warn-log the case of incomplete name-description
90fec67 
Incomplete = only one of name-description is provided
@pzygielo pzygielo force-pushed the name-description-warning branch from b6092a5 to 90fec67 Compare February 2, 2022 18:36
@pzygielo pzygielo marked this pull request as ready for review February 2, 2022 19:00
@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 2, 2022

@slawekjaranowski - squashed.
Please review.

@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 4, 2022

Just out of curiosity of the failures on cloudbees - as I don't know where the jenkins pipeline source is stored and if it's publicly available at all. (If it is I'd be happy to learn its location.)

The master - green one:

$ curl --silent https://ci-maven.apache.org/blue/rest/organizations/jenkins/pipelines/Maven/pipelines/maven-github/pipelines/maven-invoker-plugin/branches/master/runs/1/log/?start=0 | grep -a "Fetching upstream"
Fetching upstream changes from https://gitbox.apache.org/repos/asf/maven-jenkins-env.git
Fetching upstream changes from https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git
Fetching upstream changes from https://github.com/apache/maven-invoker-plugin.git
[...]
Fetching upstream changes from https://github.com/apache/maven-invoker-plugin.git

while the failing build for this PR:

$ curl --silent https://ci-maven.apache.org/blue/rest/organizations/jenkins/pipelines/Maven/pipelines/maven-github/pipelines/maven-invoker-plugin/branches/PR-97/runs/1/log/?start=0 | grep -a "Fetching upstream"
Fetching upstream changes from https://gitbox.apache.org/repos/asf/maven-jenkins-env.git
Fetching upstream changes from https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git

So it seems that checkout of the project was not successful, however the build (next step I presume) was started regardless?

@slawekjaranowski
Copy link
Member

Jenkins pipeline projects:
https://github.com/apache/maven-jenkins-lib
https://github.com/apache/maven-jenkins-env

@slawekjaranowski
Copy link
Member

@olamy what happens here ... why some of check are green and some are red

@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 4, 2022

Jenkins pipeline projects: https://github.com/apache/maven-jenkins-lib https://github.com/apache/maven-jenkins-env

Oh I see, it's from here:

maven-invoker-plugin/Jenkinsfile

Line 20 in 0ab1c94

asfMavenTlpPlgnBuild()

+ above. Thanks!

@slawekjaranowski slawekjaranowski merged commit e3f664d into apache:master Feb 9, 2022
@pzygielo pzygielo deleted the name-description-warning branch February 10, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzygielo @slawekjaranowski