[MSHARED-1290] Fix PropertyUtils cycle detection results in false positives #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
Signed-off-by: Wouter Born <[email protected]>
elharo
reviewed
Oct 22, 2023
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Can the tests be written without inspecting the logger? Logger messages are often side effects that change a lot and shouldn't break unrelated tests
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for having a look! I've addressed your review comments in the new commit @elharo. |
elharo
previously requested changes
Oct 22, 2023
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Oct 23, 2023
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Dec 8, 2023
|
Resolve #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MSHARED-1290 which was caused by apache/maven-shared#17.