replace deprecated code in favor of Java 7 core and apache commons libraries #13
Conversation
dennisl
left a comment
dennisl
left a comment
There was a problem hiding this comment.
I think that you should not remove the local variables delimiters in AbstractMavenFilteringRequestTest, since it makes the tests prone to interference from the other tests in the class.
|
This is a common misconception. Instance fields are not shared between test methods. |
|
My bad. Then we are good to go! |
elharo
changed the title
| emptyDirectoryChildEmptyChild.mkdirs(); | ||
|
|
||
| FileUtils.fileWrite( new File( emptyDirectoryChildEmptyChild, ".gitignore" ), "UTF-8", "# .gitignore file" ); | ||
| FileUtils.write( new File( emptyDirectoryChildEmptyChild, ".gitignore" ), "# .gitignore file", "UTF-8" ); |
There was a problem hiding this comment.
simply using Files.write could avoid external dependencies
There was a problem hiding this comment.
not quite a 1:1 replacement. What we really need is Files.writeString from Java 11. We'd also need to change the File objects to Path objects. I'll leave this change for a separate PR if someone wants to take it.
|
java.io.FileNotFoundException: File does not exist: /home/jenkins/jenkins-slave/workspace/maven-box_maven-filtering_i912/m/target/sourceTestGitIgnoreFile |
|
Passes locally though. |
3 participants
No description provided.