Wouter Born opened MSHARED-1290 and commented

I upgraded the maven-assembly-plugin in one of my projects from 2.6 to 3.6.0 and found that PropertyUtils was logging many false positives about cycles between properties.

The cycle detection (introduced for MSHARED-417) reports false positives when a variable occurs multiple times in a property, example:

depends=p1 >= ${version}, p2 >= ${version}, p3 >= ${version}
version=1.2.3 

While writing a unit test to fix this, I also found that there are also cycle false positives whenever one of the property values is the same as a property name, example:

test1=${test2}
test2=${test3}
test3=test2

Affects: maven-filtering-3.2.0, maven-filtering-3.3.0, maven-filtering-3.3.1

Issue Links:

• MSHARED-417 Infinite loop when loading self-referencing properties

Remote Links:

• GitHub Pull Request #78
  
• PR causing the issue