Skip to content

Conversation

@pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jun 9, 2025

I hope this can help with the release to have finally

out.


* Version 3.4.0

* Require <Java 8> and <Maven 3.6.3> at least.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should say
Require <Maven 3.6.3> at least.
as the diff wrt 3.3.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After look at page: https://maven.apache.org/plugins/maven-ear-plugin/
I would not add info that diff wrt 3.3.0 ...
it is on one simple page


* Require <Java 8> and <Maven 3.6.3> at least.

* Support <Jakarta EE 9>, <10> and <11>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should say
Support <Jakarta EE 11>.
as the diff wrt 3.3.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ... I see 11 is as additional to previous, so it is rationale 😄

@slawekjaranowski
Copy link
Member

@pzygielo thanks .... so I will release next version after it 😄

@slawekjaranowski slawekjaranowski self-assigned this Jun 9, 2025
@pzygielo
Copy link
Contributor Author

pzygielo commented Jun 9, 2025

Thanks for checking @slawekjaranowski!

Should I push the shorter versions as I suggested? Or leave them as they are currently in this PR?

@slawekjaranowski
Copy link
Member

Should I push the shorter versions as I suggested? Or leave them as they are currently in this PR?

@pzygielo - please try with suggested version 😄

@slawekjaranowski slawekjaranowski added this to the 3.4.0 milestone Jun 9, 2025
@slawekjaranowski slawekjaranowski added the documentation Improvements or additions to documentation label Jun 9, 2025
@pzygielo
Copy link
Contributor Author

pzygielo commented Jun 9, 2025

please try with suggested version

Done

@slawekjaranowski slawekjaranowski merged commit 2f21212 into apache:master Jun 10, 2025
20 checks passed
@pzygielo pzygielo deleted the r340 branch June 10, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants