-
Notifications
You must be signed in to change notification settings - Fork 25
Prepare for 3.4.0 release #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/site/apt/index.apt.vm
Outdated
|
|
||
| * Version 3.4.0 | ||
|
|
||
| * Require <Java 8> and <Maven 3.6.3> at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should say
Require <Maven 3.6.3> at least.
as the diff wrt 3.3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After look at page: https://maven.apache.org/plugins/maven-ear-plugin/
I would not add info that diff wrt 3.3.0 ...
it is on one simple page
src/site/apt/index.apt.vm
Outdated
|
|
||
| * Require <Java 8> and <Maven 3.6.3> at least. | ||
|
|
||
| * Support <Jakarta EE 9>, <10> and <11>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should say
Support <Jakarta EE 11>.
as the diff wrt 3.3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ... I see 11 is as additional to previous, so it is rationale 😄
|
@pzygielo thanks .... so I will release next version after it 😄 |
|
Thanks for checking @slawekjaranowski! Should I push the shorter versions as I suggested? Or leave them as they are currently in this PR? |
@pzygielo - please try with suggested version 😄 |
Done |
I hope this can help with the release to have finally
out.