This repository was archived by the owner on Sep 18, 2025. It is now read-only.
[MNG-6847] Use diamond operator#10
Merged
elharo merged 2 commits intoapache:masterfrom Sep 27, 2023
Merged
Conversation
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/SEvWu02zw?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <[email protected]>
elharo
approved these changes
Sep 26, 2023
timtebeek
commented
Sep 26, 2023
timtebeek
deleted the
refactor/simplify-boolean-expressions-and-returns
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/SEvWu02zw?organizationId=QXBhY2hlIE1hdmVu
@elharo since there's a long tail of projects that can still pick up diamond operators, I've started to combine those with the low volume simplify conditional expression.
Figured that'd strike the right balance between still delivering value, while also minimizing PRs and reviews.