[MDEPLOY-206] Support parallel deployment for deployAtEnd#35
[MDEPLOY-206] Support parallel deployment for deployAtEnd#35slawekjaranowski merged 1 commit intomasterfrom
Conversation
Each whole module will be deployed by resolver in one thread. We have parallel deployment on module level.
|
@slawekjaranowski the code for multi-threaded deploy should work if the number of threads is set to |
In case we really want to avoid creating a thread pool with 1 thread, we could use https://guava.dev/releases/19.0/api/docs/com/google/common/util/concurrent/MoreExecutors.html#newDirectExecutorService() ... |
|
There are two code paths:
|
|
@gnodet Is my answer sufficient for you? |
That is the reason that I execute deploy for whole module in separate thread - we have the same situation like executing Maven with |
| * | ||
| * @since 3.1.0 | ||
| */ | ||
| @Parameter(property = "maven.deploy.parallelThreads", defaultValue = "1") |
There was a problem hiding this comment.
sorry for the late review.
Would it be possible to support dynamic syntax like is done with the CLI parallelism flag -T 1C that way the deploy threads could scale with the hardware without being tightly coupled to config.
And I agree, this should be better solved in resolver (would be nicer at least). IMO this plugin should simply create 1 deploy request and lump it onto resolver to "solve it". |
|
Resolve #480 |
5 participants
Each whole module will be deployed by resolver in one thread.
We have parallel deployment on module level.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEPLOY-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MDEPLOY-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.