Skip to content

[MCHECKSTYLE-432] Inline configuration does not work when creating si…#113

Closed
michael-o wants to merge 1 commit intomasterfrom
fix
Closed

[MCHECKSTYLE-432] Inline configuration does not work when creating si…#113
michael-o wants to merge 1 commit intomasterfrom
fix

Conversation

@michael-o
Copy link
Copy Markdown
Member

…te reports with multiple locales

Co-authored-by: Peter Lamby [email protected]

This closes #112 and closes #113

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCHECKSTYLE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…te reports with multiple locales

Co-authored-by: Peter Lamby <[email protected]>

This closes #112 and closes #113
Copy link
Copy Markdown
Contributor

@Serranya Serranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@michael-o
Copy link
Copy Markdown
Member Author

Merged.

@michael-o michael-o closed this Apr 18, 2023
@michael-o michael-o deleted the fix branch April 18, 2023 14:24
@jira-importer
Copy link
Copy Markdown

Resolve #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants