Skip to content

set Maven 3.1.1 as minimum version #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elharo merged 1 commit into from
Apr 27, 2020
Merged

set Maven 3.1.1 as minimum version #6

elharo merged 1 commit into from
Apr 27, 2020

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Apr 24, 2020

@michael-o
Copy link
Member

michael-o commented Apr 24, 2020

Can you please explain why?

@elharo
Copy link
Contributor Author

elharo commented Apr 24, 2020

Toe in the water to move all plugins forward to 3.1 as minimum as discussed on dev. This is the first one I've found where this was actually simple.

@elharo
Copy link
Contributor Author

elharo commented Apr 27, 2020

Test failures might be flaky Jenkins issues, needs investigation:

[INFO] ------------------------------------------------------------------------
[INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-slave/workspace/maven-box_maven-antrun-plugin_v@2@tmp/withMavenafba2237/maven-spy-20200424-135936-2555145151326151625751.log
[ERROR] unable to create new native thread -> [Help 1]
java.lang.OutOfMemoryError: unable to create new native thread

@elharo
Copy link
Contributor Author

elharo commented Apr 27, 2020

Yep, it was flaky CI. It passed now.

@elharo elharo merged commit 1e63614 into master Apr 27, 2020
@elharo elharo deleted the v branch April 27, 2020 14:24
@rfscholte
Copy link
Contributor

rfscholte commented Apr 27, 2020

this should have been 3.1.0. The difference between api and impl is not clear, but as a result of earlier discussions this should the lower version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elharo @michael-o @rfscholte