[MNG-8180] Back out from failing the build #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just warn for now, we cannot go from builds-ok w/ 3.9.8 to fails-the-build in 3.9.9. Warning can raise awareness, and this pattern is bad as it is, but users now become aware that they may have rogue plugin.xml (just like maven-compat had). The original bug is fixed (Maven deploys unrelated metadata). --- https://issues.apache.org/jira/browse/MNG-8180
gnodet
approved these changes
Aug 12, 2024
slawekjaranowski
approved these changes
Aug 12, 2024
cstamas
added a commit
that referenced
this pull request
Aug 12, 2024
Just warn the user for now. Port of accepted change from 3.9.x: #1642 --- https://issues.apache.org/jira/browse/MNG-8180
cstamas
pushed a commit
that referenced
this pull request
Aug 12, 2024
cstamas
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just warn for now, we cannot go from builds-ok w/
3.9.8 to fails-the-build in 3.9.9. Warning
can raise awareness, and this pattern is bad as
it is, but users now become aware that they may
have rogue plugin.xml (just like maven-compat had).
The original bug is fixed (Maven deploys unrelated metadata).
Same change is to be ported to master as well.
https://issues.apache.org/jira/browse/MNG-8180