Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/maven
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8b094c9
Choose a base ref
...
head repository: apache/maven
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 36645f6
Choose a head ref
  • 19 commits
  • 51 files changed
  • 5 contributors

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    1c166ab View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    1f97d9f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    2a43483 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    9ee3963 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2fa050 View commit details
    Browse the repository at this point in the history
  3. [MNG-7902] Sort plugins in the validation report (#1510)

    Co-authored-by: Yueh Chun Wu <[email protected]>
    
    (cherry picked from commit dd96794)
    yuehcw authored and slawekjaranowski committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    df00ea5 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    8650720 View commit details
    Browse the repository at this point in the history
  2. [MNG-8142] Hidden bug: JDK profile activator throw NumberFormatEx (#1557

    )
    
    If property `java.version` is in unexpected format, the activator throws `NumberFormatEx`, that in turn, is caught and reported by `DefaultProfileSelector` w/o any cause.
    
    These should be cleanly reported instead: report that `java.version` property is in "unexpected format", and also report why was there are failure to evaluate a property activation.
    
    Note 1: Maven allows `-Djava.version` override (!!!), this is exactly what IT MNG-3746 does, but the `NumberFormatEx` went unnoticed, was swallowed, no cause reported.
    
    Note 2: This bug was revealed by #1555 as it reported the issue, and later "asserted error free log" which was not error-free. Hence, this bug was simply revealed by improved logging on unrelated issue.
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-8142
    cstamas authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    200dc02 View commit details
    Browse the repository at this point in the history
  3. [MNG-8146] Drop commons-lang (#1564)

    For start, keeping almost same LOC but the distro zip lost almost 1 MB (was 10MB now is 9MB). Second, am really unsure why it was introduced in the first place, as it merely caused confusion, over StringUtils for example.
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-8146
    cstamas authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    741deac View commit details
    Browse the repository at this point in the history
  4. [MNG-8140] Always tell why model was discarded as "invalid" (#1555)

    The info is there, but we redirect user to rinse-repeat in debug mode, that that creates a TON of output.
    
    All is there, just tell why.
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-8140
    cstamas authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    66266e5 View commit details
    Browse the repository at this point in the history
  5. [MNG-8141] Model builder should report problems it finds during build (

    …#1556)
    
    And not rely that model was validated, which is not true in some cases. Model builder can still easily detect issues with models while building them.
    
    Provides "escape hatch" for projects stuck on invalid models in form of user property that can be enabled with `-Dmaven.modelBuilder.failOnInvalidModel=false`, this reverts to _old_ behaviour of maven, and the JavaFX reproducer goes back to error "unable to resolve" errors with uninterpolated `${javafx.platform}` property as classifier.
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-8141
    cstamas authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7fcd8c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Revert "[MNG-8141] Model builder should report problems it finds duri…

    …ng build (#1556)"
    
    This reverts commit 7fcd8c5.
    cstamas committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    758e054 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. [MNG-8141][MNG-8147] Restore profile ID invariance but warn if duplic…

    …ate IDs present (#1568)
    
    Fix and improvement in one PR as they are closely related.
    First, this PR restores the ability (broken by MNG-8081) to calculate Profile activation for POMs with duplicate Profile ID.
    Second, this PR improves UX by warning them about invalid models in their build.
    
    The reproducer now looks like this:
    https://gist.github.com/cstamas/165a610b233f4c03e381a0a2697903eb
    
    Notice:
    * WARNs issued about models (all Maven versions are mute about this)
    * still, property `${javafx.platform}` properly evaluated just like in 3.9.6 (but not in 3.9.7)
    * build succeeds (fails in 3.9.7)
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-8147
    https://issues.apache.org/jira/browse/MNG-8141
    cstamas authored Jun 8, 2024
    Configuration menu
    Copy the full SHA
    dd8c95c View commit details
    Browse the repository at this point in the history
  2. Reformat, no code change

    cstamas committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    ac5d71a View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. [MNG-8141] Aftermath, and tidy up (#1572)

    No (logic) change, merely moved the new code to proper place (validation) to not piggy back onto processing: this is much cleaner.
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-8141
    
    Inspired by suggestions in master PR #1569
    cstamas authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    02927b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    083716d View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. [MNG-7758] Report dependency problems for all repository

    (cherry picked from commit 768ebbc)
    slawekjaranowski committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    37f1f02 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    105d843 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    36645f6 View commit details
    Browse the repository at this point in the history
Loading