[MNG-7902] Sort plugins in the validation report (#1510)

yuehcw · Yueh Chun Wu · web-flow · commit dd9679450e00 · 2024-05-23T14:25:04.000+02:00
Co-authored-by: Yueh Chun Wu &lt;kevinwu@YuehdeMBP.attlocal.net&gt;
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
@@ -23,6 +23,7 @@
 
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ -222,7 +223,12 @@ private void reportSessionCollectedValidationIssues(MavenSession mavenSession) {
             logger.warn("");
             logger.warn("Plugin {} validation issues were detected in following plugin(s)", issueLocalitiesToReport);
             logger.warn("");
-            for (Map.Entry<String, PluginValidationIssues> entry : issuesMap.entrySet()) {
+
+            // Sorting the plugins
+            List<Map.Entry<String, PluginValidationIssues>> sortedEntries = new ArrayList<>(issuesMap.entrySet());
+            sortedEntries.sort(Map.Entry.comparingByKey(String.CASE_INSENSITIVE_ORDER));
+
+            for (Map.Entry<String, PluginValidationIssues> entry : sortedEntries) {
                 PluginValidationIssues issues = entry.getValue();
                 if (!hasAnythingToReport(issues, issueLocalitiesToReport)) {
                     continue;
