Repository navigation
eperf(skills): load conditional shared text only when it applies - #1996
Merged
Merged
Conversation
Move text that only some runs need out of SKILL.md into sibling files, behind pointers that name when to read them: the tracker-backend detail (12 skills), the pre-PR adversarial review (8), the item failure budget (6), and the failure-modes tables of issue-triage and issue-stale-sweep. Shared text moves byte-for-byte, and no surface hash changes. All four skills that were over the 500-line cap are now within it. Add pointer-routing eval steps to issue-triage and security-issue-fix. They show the agent the whole skill without the sibling text, because the existing suites paste that text into the prompt and so cannot tell whether a pointer is followed. Generated-by: Claude Opus 5
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL.mdinto sibling files, behind pointers that name when to read them, so a run stops paying for branches it never takes.skill-line-limitwarnings, and takes the skills over the 5,000-token body target from 22 to 17 (estimates, characters ÷ 4).pointer-routingeval steps, because the existing suites cannot tell whether a pointer is followed.tracker-backenddetailtracker.platformislocal-filesorjirapre-pr-adversarial-reviewitem-failure-budgetrule## Failure modestabletracker-backendanditem-failure-budgeteach split into a pointer block that stays inSKILL.mdand a new-detailblock in the sibling.pre-pr-adversarial-reviewfollows whatissue-fix-workflowandaudit-finding-fixalready do.The generator and validator did not need changing.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowdocs/,README.md,CONTRIBUTING.md)Test plan
prek run --all-files --skip workspace-pytestpasses, includinglycheeworkspace-pytestpasses for the changed filesskill-line-limitwarnings 4 → 0surface_hashchanged, so adopters are not told their configuration went stalepointer-routingsteps: 12 cases, also run against throwaway copies with the pointers deletedThe 45/45 result is partial evidence:
also_includepastes the sibling into the prompt, so those suites show that the moved rules still work, not that an agent reaches them.pointer-routingcovers that gap by giving the agent the whole body and no sibling text.security-issue-fix/pointer-routingissue-triage/pointer-routingThe first version of this test passed 6/6 on
security-issue-fixwith both pointers deleted, because its output spec listed the filenames.The spec now names no file, so the agent has to get each name from the skill text.
issue-triagecase-2failed once on the real skill with a pool of 12, most likely because that also triggers the N > 5bulk-mode.mdpointer (the runner does not show the extra file).With a pool of 4 and the same expected answer it passed 3/3 on the real skill and failed on the copy without pointers.
RFC-AI-0004 compliance
check-placeholdershook passesNo mutation, host access, outbound message or LLM routing changes.
Linked issues
None.
Notes for reviewers
pointer-routingexercises two skills. Theissue-stale-sweepfailure-modes pointer has its own wording and is untested, and the pre-PR pointer was placed by hand in 8 skills but tested in one.security-issue-import-from-prlikely always does; its gain is getting under the line cap.tools/spec-loop/.last-syncis not bumped. The specs for these blocks are updated by hand here; it is 62 commits behindmainfor reasons unrelated to this PR.🤖 Generated with Claude Code