Clean up how the test framework creates asserting scorables. #14452
Conversation
This removes the `WrappedScorer` class and uses the existing `AssertingScorer` class instead.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
The refactoring looks good, even cleans up some unused code like AssertingScorer#random. Minor comment to understand it better
| assert scoreMode == ScoreMode.TOP_SCORES; | ||
| assert canCallMinCompetitiveScore; | ||
| assert canScore; | ||
| assert canSetMinCompetitiveScore; |
There was a problem hiding this comment.
Still trying to understand this code better, but it seems that the assertion statement is weaker now. Earlier, it was specifically scoreMode == ScoreMode.TOP_SCORES, and now it is scoreMode.needsScores(). Do we allow it for other scoreMode that needsScores now?
There was a problem hiding this comment.
This is a good point, I pushed a commit that makes sure setMinCompetitiveScore may only be called with TOP_SCORES.
jpountz
force-pushed
the
clean_up_test_framework_asserting_scorable
branch
from
6a1ed37 to
72085d9
Compare
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
This removes the `WrappedScorer` class and uses the existing `AssertingScorer` class instead.
* main: (32 commits) update os.makedirs with pathlib mkdir (apache#14710) Optimize AbstractKnnVectorQuery#createBitSet with intoBitset (apache#14674) Implement #docIDRunEnd() on PostingsEnum. (apache#14693) Speed up TermQuery (apache#14709) Refactor main top-n bulk scorers to evaluate hits in a more term-at-a-time fashion. (apache#14701) Fix WindowsFS test failure seen on Policeman Jenkins (apache#14706) Use a temporary repository location to download certain ecj versions ("drops") (apache#14703) Add assumption to ignore occasional test failures due to disconnected graphs (apache#14696) Return MatchNoDocsQuery when IndexOrDocValuesQuery::rewrite does not match (apache#14700) Minor access modifier adjustment to a couple of lucene90 backward compat types (apache#14695) Speed up exhaustive evaluation. (apache#14679) Specify and test that IOContext is immutable (apache#14686) deps(java): bump org.gradle.toolchains.foojay-resolver-convention (apache#14691) deps(java): bump org.eclipse.jgit:org.eclipse.jgit (apache#14692) Clean up how the test framework creates asserting scorables. (apache#14452) Make competitive iterators more robust. (apache#14532) Remove DISIDocIdStream. (apache#14550) Implement AssertingPostingsEnum#intoBitSet. (apache#14675) Fix patience knn queries to work with seeded knn queries (apache#14688) Added toString() method to BytesRefBuilder (apache#14676) ...
2 participants
This removes the
WrappedScorerclass and uses the existingAssertingScorerclass instead.