Make segment/field attribute updates thread-safe. #13331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of concurrent merging (apache#13124), multiple threads may be updating (different) attributes concurrently, so we need to make reads and writes to attributes thread-safe.
benwtrent
reviewed
Apr 30, 2024
| String oldValue = newMap.put(key, value); | ||
| // This needs to be thread-safe as multiple threads may be updating (different) attributes | ||
| // concurrently due to concurrent merging. | ||
| attributes = Collections.unmodifiableMap(newMap); |
Member
There was a problem hiding this comment.
I don't understand why we are copying the map, why not use a ConcurrentHashMap?
Is this because we don't want this changing at all after something calls attributes()?
Contributor
Author
There was a problem hiding this comment.
Indeed. Since SegmentInfo's attributes were already using this approach, I thought it made sense to follow the same approach instead of doing something different.
benwtrent
approved these changes
Apr 30, 2024
jpountz
added a commit
that referenced
this pull request
May 6, 2024
Because of concurrent merging (#13124), multiple threads may be updating (different) attributes concurrently, so we need to make reads and writes to attributes thread-safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of concurrent merging (#13124), multiple threads may be updating (different) attributes concurrently, so we need to make reads and writes to attributes thread-safe.