Disable ConcurrentMergeScheduler's auto I/O throttling by default. #13293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by the fact that merges can hardly steal all I/O resources from searches on modern NVMe drives. Merges are still not allowed to use all CPU since they have a budget for the number of threads which is a fraction of the number of threads that the host can run. Closes apache#13193
mikemccand
approved these changes
Apr 11, 2024
Member
mikemccand
left a comment
mikemccand
left a comment
There was a problem hiding this comment.
Thanks @jpountz! How times have changed (from spinning magnets to tiny transistors)...
|
|
||
| /** true if we should rate-limit writes for each merge */ | ||
| private boolean doAutoIOThrottle = true; | ||
| private boolean doAutoIOThrottle = false; |
Member
There was a problem hiding this comment.
Maybe just remove the = false since it's java's default.
Contributor
Author
There was a problem hiding this comment.
I liked it being explicit to show that it's false by default on purpose rather than just because false is the default value for a Java boolean?
Contributor
There was a problem hiding this comment.
Please make those explcit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable ConcurrentMergeScheduler's auto I/O throttling by default.
This is motivated by the fact that merges can hardly steal all I/O resources
from searches on modern NVMe drives. Merges are still not allowed to use all
CPU since they have a budget for the number of threads which is a fraction of
the number of threads that the host can run.
Closes #13193