[BROKEN, for reference only] concurrent hnsw #12683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
zhaih
reviewed
Oct 16, 2023
| * @param node ordinal of a node in the graph, must be ≥ 0 and < {@link HnswGraph#size()}. | ||
| */ | ||
| public NeighborIterator lockNeighbors(int level, int node) throws IOException { | ||
| throw new UnsupportedOperationException("concurrent access not implemented"); |
Contributor
There was a problem hiding this comment.
Will this break back-compatibility? (e.g. when reading a Lucene90 index and we're not able to search on it because the off heap graph there did not implement this?)
Contributor
Author
There was a problem hiding this comment.
ah true. I think the impl for Lucene95HnswVectorsReader.OffHeapHnswGraph can be moved up to here
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds row locks to OnHeapHnswGraph
seems to be broken in the way it adds new nodes to upper levels such that they become discoverable before they have neighbors?
I shared this mostly because we might want to integrate the
NeighborIteratorin order to keep changes localized to theHnswGraphclasses and not inHnswGraphSearcher. Also this has the idea of passing in anExecutorServicerather than creating one in the util/hnsw