Clean up residual module-info.class before compilation
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
approved these changes
Jan 11, 2024
Add rule to ban wildcard imports. Wildcard imports are often the only difference between branches and they can not easily be expanded by Spotless. Fixes apache#63.
This adds [`jspecify`](https://jspecify.dev/) to the dependency management, a common effort of multiple Java tool developers to provide a common set of nullability annotations. Fixes apache#88.
We add a `maven-clean-plugin` execution to remove any trailing `module-info.class` files before each compilation. Such files can cause problem like in: https://github.com/copernik-eu/bug-reproducibility/tree/main/javac-module-info-bug
ppkarwasz
force-pushed
the
90_delete_module_descriptor
branch
from
eaed378 to
53d2fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a
maven-clean-pluginexecution to remove any trailingmodule-info.classfiles before each compilation.Such files can cause problem like in:
https://github.com/copernik-eu/bug-reproducibility/tree/main/javac-module-info-bug
Closes #90.