Add collectionName and databaseName attributes to MongoDbProvider
#3702
Conversation
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing #3322!
Just a quick note on the tests in the log4j-mongodb module:
- The newly added integration tests (
CollectionNameIT,DatabaseAndCollectionNameIT, andNoDatabaseAndCollectionNameIT) seem somewhat redundant. From what I can tell, the existingProviderTestunit test already verifies that the correct strings are passed to the MongoDB driver, so these ITs might not add much value beyond that. - Not directly related to this PR, but something we might want to track: the
CappedIntITandCappedLongITtests don’t appear to actually verify that the collection created is capped. It could be worth opening an issue to address that.
When I get a chance, I’ll try porting this PR over to the 2.x branch. After that, maybe we can switch roles—I'll open the PR, and you can do the honors of reviewing. 😉
|
@ppkarwasz, removed |
github-project-automation
bot
moved this from Approved
to Merged
in Log4j pull request tracker
I think I was mistakenly looking at the BTW: regarding |
Doh! Never occurred to me either! 🤦♂️ I guess we are both experiencing "burnout as a life style"? 😅 |
3 participants
This work is a clone of #3322 authored by @jesmith17. Commit signatures were missing, Spotless was failing, and author could not address these issues. I created a separate PR to avoid truncating the git & GitHub conversation history in the old PR.