[TEST] Fix loglevel restore behavior of KyuubiFunSuite#withLogAppender
#4985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4985 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 561 561
Lines 30953 30953
Branches 4063 4063
======================================
Misses 30953 30953 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cxzl25
approved these changes
Jun 23, 2023
pan3793
added a commit
that referenced
this pull request
Jun 25, 2023
…e#withLogAppender` ### _Why are the changes needed?_ This method is forked from Apache Spark, and recently, [SPARK-44074](apache/spark#41663) identified and fixed the issue about loglevel restore behavior. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes #4985 from pan3793/test-log. Closes #4985 4c05bc5 [Cheng Pan] Fix loglevel restore behavior of `KyuubiFunSuite#withLogAppender` Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit a622c0a) Signed-off-by: Cheng Pan <[email protected]>
Member
Author
|
Thanks, merged master/1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This method is forked from Apache Spark, and recently, SPARK-44074 identified and fixed the issue about loglevel restore behavior.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request