[KYUUBI #417] [MINOR] Remove all unused import

谢波 · MyLanPangzi · pan3793 · commit 9c13f73bd9c3 · 2021-03-15T20:05:08.000+08:00
![MyLanPangzi](https://badgen.net/badge/Hello/MyLanPangzi/green) [![Closes #417](https://badgen.net/badge/Preview/Closes%20%23417/blue)](https://github.com/yaooqinn/kyuubi/pull/417) ![29](https://badgen.net/badge/%2B/29/red) ![27](https://badgen.net/badge/-/27/green) ![7](https://badgen.net/badge/commits/7/yellow) ![Target Issue](https://badgen.net/badge/Missing/Target%20Issue/ff0000) ![Test Plan](https://badgen.net/badge/Missing/Test%20Plan/ff0000) [&#10088;?&#10089;](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info) ### _Why are the changes needed?_ remove all unused import and replace deprecated class PersistentEphemeralNode with PersistentNode in ServiceDiscovery ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Closes #417 from MyLanPangzi/master. 821e0d2 [hiscat] Merge branch 'master' into master db9cd3c [谢波] [MINOR]: revert ServiceDiscovery change and add scala maven plugin compiler args c56cd2b [谢波] [MINOR]: revert ProcBuilder indent ad5e24a [谢波] [MINOR]: revert maven.plugin.scalatest.exclude.tags properties 7c23e37 [谢波] [MINOR]: scala maven plugin config move to plugin management 6029b99 [谢波] [MINOR]: remove all unused import a305567 [谢波] [MINOR]: remove all unused import Lead-authored-by: 谢波 <xiebo1@yonghui.cn> Co-authored-by: hiscat <46845236+MyLanPangzi@users.noreply.github.com> Signed-off-by: Cheng Pan <379377944@qq.com>
diff --git a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLBackendService.scala b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLBackendService.scala
@@ -20,18 +20,17 @@ package org.apache.kyuubi.engine.spark
 import org.apache.spark.sql.SparkSession
 
 import org.apache.kyuubi.engine.spark.session.SparkSQLSessionManager
-import org.apache.kyuubi.operation.Operation
 import org.apache.kyuubi.service.AbstractBackendService
-import org.apache.kyuubi.service.BackendService
-import org.apache.kyuubi.session.Session
 import org.apache.kyuubi.session.SessionManager
 
 /**
- * A [[BackendService]] constructed with [[SparkSession]] which give it the ability to talk with
+ * A [[org.apache.kyuubi.service.BackendService]] constructed
+ * with [[SparkSession]] which give it the ability to talk with
  * Spark and let Spark do all the rest heavy work :)
  *
  *  @param name  Service Name
- * @param spark A [[SparkSession]] instance that this backend service holds to run [[Operation]]s.
+ *  @param spark A [[SparkSession]] instance
+ *               that this backend service holds to run [[org.apache.kyuubi.operation.Operation]]s.
  */
 class SparkSQLBackendService(name: String, spark: SparkSession)
   extends AbstractBackendService(name) {
diff --git a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/schema/RowSet.scala b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/schema/RowSet.scala
@@ -23,7 +23,7 @@ import java.sql.Timestamp
 import java.text.SimpleDateFormat
 import java.time.{Instant, LocalDate, ZoneId}
 import java.time.chrono.IsoChronology
-import java.time.format.{DateTimeFormatter, DateTimeFormatterBuilder, ResolverStyle}
+import java.time.format.{DateTimeFormatter, DateTimeFormatterBuilder}
 import java.time.temporal.ChronoField
 import java.util.{Date, Locale}
 
diff --git a/externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/session/SessionSuite.scala b/externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/session/SessionSuite.scala
@@ -20,9 +20,8 @@ package org.apache.kyuubi.engine.spark.session
 import org.scalatest.concurrent.PatienceConfiguration.Timeout
 import org.scalatest.time.SpanSugar._
 
-import org.apache.kyuubi.Utils
 import org.apache.kyuubi.config.KyuubiConf._
-import org.apache.kyuubi.engine.spark.{SparkSQLEngine, WithSparkSQLEngine}
+import org.apache.kyuubi.engine.spark.WithSparkSQLEngine
 import org.apache.kyuubi.operation.JDBCTestUtils
 import org.apache.kyuubi.service.ServiceState._
 
diff --git a/kyuubi-common/pom.xml b/kyuubi-common/pom.xml
@@ -33,11 +33,6 @@
 
     <dependencies>
 
-        <dependency>
-            <groupId>org.scala-lang</groupId>
-            <artifactId>scala-library</artifactId>
-        </dependency>
-
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/BackendService.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/BackendService.scala
@@ -19,19 +19,19 @@ package org.apache.kyuubi.service
 
 import org.apache.hive.service.rpc.thrift._
 
-import org.apache.kyuubi.operation.{Operation, OperationHandle, OperationStatus}
+import org.apache.kyuubi.operation.{OperationHandle, OperationStatus}
 import org.apache.kyuubi.operation.FetchOrientation.FetchOrientation
-import org.apache.kyuubi.session.{Session, SessionHandle, SessionManager}
+import org.apache.kyuubi.session.{SessionHandle, SessionManager}
 
 /**
  * A [[BackendService]] in Kyuubi architecture is responsible for talking to the SQL engine
  *
- * 1. Open/Close [[Session]]
- * 2. Operate [[Operation]]
- * 3. Manager [[Session]]s via [[SessionManager]]
- * 4. Check [[OperationStatus]]
- * 5. Retrieve [[Operation]] results and metadata
- * 6. Cancel/Close [[Operation]]
+ * 1. Open/Close [[org.apache.kyuubi.session.Session]] <br/>
+ * 2. Operate [[org.apache.kyuubi.operation.Operation]] <br/>
+ * 3. Manager [[org.apache.kyuubi.session.Session]]s via [[SessionManager]] <br/>
+ * 4. Check [[OperationStatus]] <br/>
+ * 5. Retrieve [[org.apache.kyuubi.operation.Operation]] results and metadata <br/>
+ * 6. Cancel/Close [[org.apache.kyuubi.operation.Operation]] <br/>
  *
  */
 trait BackendService {
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/FrontendService.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/FrontendService.scala
@@ -41,7 +41,6 @@ class FrontendService private (name: String, be: BackendService, oomHook: Runnab
 
   import FrontendService._
   import KyuubiConf._
-  import OperationHandle._
 
   def this(be: BackendService, oomHook: Runnable) = {
     this(classOf[FrontendService].getSimpleName, be, oomHook)
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/PlainSASLHelper.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/PlainSASLHelper.scala
@@ -20,8 +20,7 @@ package org.apache.kyuubi.service.authentication
 import java.security.Security
 import java.util.Collections
 import javax.security.auth.callback.{Callback, CallbackHandler, NameCallback, PasswordCallback, UnsupportedCallbackException}
-import javax.security.auth.login.LoginException
-import javax.security.sasl.{AuthenticationException, AuthorizeCallback}
+import javax.security.sasl.AuthorizeCallback
 
 import org.apache.hive.service.rpc.thrift.TCLIService.Iface
 import org.apache.thrift.{TProcessor, TProcessorFactory}
diff --git a/kyuubi-common/src/test/scala/org/apache/kyuubi/operation/NoopOperationManager.scala b/kyuubi-common/src/test/scala/org/apache/kyuubi/operation/NoopOperationManager.scala
@@ -17,7 +17,7 @@
 
 package org.apache.kyuubi.operation
 
-import org.apache.hive.service.rpc.thrift.{TRow, TRowSet}
+import org.apache.hive.service.rpc.thrift.TRowSet
 
 import org.apache.kyuubi.operation.FetchOrientation.FetchOrientation
 import org.apache.kyuubi.session.Session
diff --git a/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ServiceDiscovery.scala b/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ServiceDiscovery.scala
@@ -24,7 +24,6 @@ import java.util.concurrent.atomic.AtomicBoolean
 import javax.security.auth.login.Configuration
 
 import scala.collection.JavaConverters._
-import scala.util.control.NonFatal
 
 import org.apache.curator.framework.{CuratorFramework, CuratorFrameworkFactory}
 import org.apache.curator.framework.recipes.nodes.PersistentEphemeralNode
diff --git a/kyuubi-main/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala b/kyuubi-main/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
@@ -30,6 +30,7 @@ import org.apache.kyuubi.config.KyuubiConf
 import org.apache.kyuubi.util.NamedThreadFactory
 
 trait ProcBuilder {
+
   import ProcBuilder._
 
   protected def executable: String
diff --git a/kyuubi-main/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala b/kyuubi-main/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala
@@ -19,7 +19,7 @@ package org.apache.kyuubi.operation
 
 import java.util.concurrent.ConcurrentHashMap
 
-import org.apache.hive.service.rpc.thrift.{TCLIService, TFetchResultsReq, TRow, TRowSet, TSessionHandle}
+import org.apache.hive.service.rpc.thrift.{TCLIService, TFetchResultsReq, TRowSet, TSessionHandle}
 
 import org.apache.kyuubi.KyuubiSQLException
 import org.apache.kyuubi.operation.FetchOrientation.FetchOrientation
diff --git a/pom.xml b/pom.xml
@@ -96,6 +96,7 @@
         <maven.plugin.dependency.version>3.1.1</maven.plugin.dependency.version>
         <maven.plugin.scalastyle.version>1.0.0</maven.plugin.scalastyle.version>
         <maven.plugin.download.version>1.6.0</maven.plugin.download.version>
+        <maven.plugin.silencer.version>1.6.0</maven.plugin.silencer.version>
         <maven.plugin.rat.version>0.13</maven.plugin.rat.version>
     </properties>
 
@@ -1022,6 +1023,9 @@
                             <arg>-feature</arg>
                             <arg>-explaintypes</arg>
                             <arg>-Yno-adapted-args</arg>
+                            <arg>-P:silencer:globalFilters=.*deprecated.*</arg>
+                            <arg>-Xfatal-warnings</arg>
+                            <arg>-Ywarn-unused:imports</arg>
                         </args>
                         <jvmArgs>
                             <jvmArg>-Xms1024m</jvmArg>
@@ -1035,6 +1039,13 @@
                             <javacArg>${java.version}</javacArg>
                             <javacArg>-Xlint:all,-serial,-path,-try</javacArg>
                         </javacArgs>
+                        <compilerPlugins>
+                            <compilerPlugin>
+                                <groupId>com.github.ghik</groupId>
+                                <artifactId>silencer-plugin_${scala.version}</artifactId>
+                                <version>${maven.plugin.silencer.version}</version>
+                            </compilerPlugin>
+                        </compilerPlugins>
                     </configuration>
                 </plugin>
 
