Skip to content

MINOR: Fix the javadoc broken links of streams#8789

Merged
bbejeck merged 1 commit intoapache:trunkfrom
vitojeng:fix-streams-broken-links
Jun 5, 2020
Merged

MINOR: Fix the javadoc broken links of streams#8789
bbejeck merged 1 commit intoapache:trunkfrom
vitojeng:fix-streams-broken-links

Conversation

@vitojeng
Copy link
Copy Markdown
Contributor

@vitojeng vitojeng commented Jun 3, 2020

There are some broken links of streams javadoc, for example:

  • ReadOnlyKeyValueStore
  • ReadOnlyWindowStore

Only javadoc is update.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vitojeng vitojeng changed the title MINOR: Fix the broken links of streams javadoc MINOR: Fix the javadoc broken links of streams Jun 3, 2020
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Jun 4, 2020

Ok to test.

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Jun 4, 2020

Java 11 failed with java.lang.OutOfMemoryError: unable to create native thread: possibly out of memory or process/resource limits reached

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Jun 4, 2020

Thanks for the contribution, @vitojeng. This PR looks good to me, I'd like to verify the links locally, but after that, we'll get this merged.

@vitojeng
Copy link
Copy Markdown
Contributor Author

vitojeng commented Jun 5, 2020

Thanks @bbejeck .

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @vitojeng! LGTM
Verified by building Javadoc locally and checking links.

@bbejeck bbejeck merged commit 31c81a6 into apache:trunk Jun 5, 2020
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Jun 5, 2020

Merged #8789 into trunk

bbejeck pushed a commit that referenced this pull request Jun 5, 2020
There are some broken links of streams javadoc, for example:

ReadOnlyKeyValueStore
ReadOnlyWindowStore
Only javadoc is update.

Reviewers: Bill Bejeck <[email protected]>
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Jun 5, 2020

cherry-picked to 2.6

Kvicii pushed a commit to Kvicii/kafka that referenced this pull request Jun 6, 2020
* 'trunk' of github.com:apache/kafka: (46 commits)
  MINOR: improve code encapsulation between StreamThread and TaskManager (apache#8819)
  Fixing KAFKA-10094 (apache#8797)
  KAFKA-9851: Revoking Connect tasks due to connectivity issues should also clear the running assignment (apache#8804)
  KAFKA-9840; Skip End Offset validation when the leader epoch is not reliable (apache#8486)
  HOT_FIX: Update javadoc since imports added (apache#8817)
  KAFKA-8011: Fix flaky RegexSourceIntegrationTest (apache#8799)
  KAFKA-9570: Define SSL configs in all worker config classes, not just distributed (apache#8135)
  KAFKA-10111: Make SinkTaskContext.errantRecordReporter() a default method (apache#8814)
  KAFKA-10110: Corrected potential NPE when null label value added to KafkaMetricsContext (apache#8811)
  MINOR: Change the order that Connect calls `config()` and `validate()` to avoid validating if the required ConfigDef is null (apache#8810)
  MINOR: fix backwards incompatibility in JmxReporter introduced by KIP-606
  MINOR: Fix javadoc warnings (apache#8809)
  KAFKA-9441: Improve Kafka Streams task management (apache#8776)
  fix the broken links of streams javadoc (apache#8789)
  KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient (apache#8724)
  KAFKA-10066: TestOutputTopic should pass record headers into deserializers (apache#8759)
  MINOR: Add explanation for disabling forwarding from value transformers (apache#8771)
  KAFKA-10033: Throw UnknownTopicOrPartitionException if altering configs of non-existing topic
  KAFKA-9434: automated protocol for alterReplicaLogDirs (apache#8311)
  KAFKA-9313: Set `use_all_dns_ips` as the new default for `client.dns.lookup` (KIP-602) (apache#8644)
  ...
ijuma added a commit to confluentinc/kafka that referenced this pull request Jun 8, 2020
Conflicts:
* build.gradle: take upstream changes regarding heap memory
configuration for the build.

* apache-github/trunk: (33 commits)
  MINOR: fix HTML markup (apache#8823)
  KAFKA-10012; Reduce overhead of strings in SelectorMetrics (apache#8684)
KAFKA-9216: Enforce internal config topic settings for Connect workers
during startup (apache#8270)
  KAFKA-10097: Internalize checkpoint data (apache#8820)
KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a
non-existent topic's config
MINOR: improve code encapsulation between StreamThread and TaskManager
(apache#8819)
  Fixing KAFKA-10094 (apache#8797)
KAFKA-9851: Revoking Connect tasks due to connectivity issues should
also clear the running assignment (apache#8804)
KAFKA-9840; Skip End Offset validation when the leader epoch is not
reliable (apache#8486)
  HOT_FIX: Update javadoc since imports added (apache#8817)
  KAFKA-8011: Fix flaky RegexSourceIntegrationTest (apache#8799)
KAFKA-9570: Define SSL configs in all worker config classes, not just
distributed (apache#8135)
KAFKA-10111: Make SinkTaskContext.errantRecordReporter() a default
method (apache#8814)
KAFKA-10110: Corrected potential NPE when null label value added to
KafkaMetricsContext (apache#8811)
MINOR: Change the order that Connect calls `config()` and `validate()`
to avoid validating if the required ConfigDef is null (apache#8810)
MINOR: fix backwards incompatibility in JmxReporter introduced by
KIP-606
  MINOR: Fix javadoc warnings (apache#8809)
  KAFKA-9441: Improve Kafka Streams task management (apache#8776)
  fix the broken links of streams javadoc (apache#8789)
KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric
more efficient (apache#8724)
  ...
@vitojeng vitojeng deleted the fix-streams-broken-links branch June 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants