KAFKA-18648: Add back support for metadata version 0-3#18716
Merged
ijuma merged 3 commits intoapache:trunkfrom Jan 29, 2025
Merged
KAFKA-18648: Add back support for metadata version 0-3#18716ijuma merged 3 commits intoapache:trunkfrom
ijuma merged 3 commits intoapache:trunkfrom
Conversation
ijuma
changed the title
ijuma
changed the title
ijuma
force-pushed
the
kafka-18648-kafka-python-metadata-version
branch
from
edf106d to
65ba914
Compare
Member
Author
|
Reopened the PR to get the CI to run. |
Member
Author
|
|
Member
|
@ijuma you can re-run the whole CI workflow in the UI. Select "Re-run all jobs" You can also push an empty commit (or just merge in trunk). |
Member
Author
Yes, I've been using that. This particular test that I mentioned keeps failing. :) |
Member
Author
|
(the reason why I reopened this PR is that GitHub didn't trigger the run after I changed the base branch and it seemed to get stuck - I usually rely on the button you shared) |
Member
Author
|
Java 23 build passed. |
ijuma
added a commit
that referenced
this pull request
Jan 29, 2025
During testing, we identified that kafka-python (and aiokafka) relies on metadata request v0 and hence we need to add these back to comply with the premise of KIP-896 - i.e. it should not break the clients listed within it. I reverted the changes from #18218 related to the removal of metadata versions 0-3. I will submit a separate PR to undeprecate these API versions on the relevant 3.x branches. kafka-python (and aiokafka) work correctly (produce & consume) with this change on top of the 4.0 branch. Reviewers: David Arthur <[email protected]>
3 tasks
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
During testing, we identified that kafka-python (and aiokafka) relies on metadata request v0 and hence we need to add these back to comply with the premise of KIP-896 - i.e. it should not break the clients listed within it. I reverted the changes from apache#18218 related to the removal of metadata versions 0-3. I will submit a separate PR to undeprecate these API versions on the relevant 3.x branches. kafka-python (and aiokafka) work correctly (produce & consume) with this change on top of the 4.0 branch. Reviewers: David Arthur <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
During testing, we identified that kafka-python (and aiokafka) relies on metadata request v0 and hence we need to add these back to comply with the premise of KIP-896 - i.e. it should not break the clients listed within it. I reverted the changes from apache#18218 related to the removal of metadata versions 0-3. I will submit a separate PR to undeprecate these API versions on the relevant 3.x branches. kafka-python (and aiokafka) work correctly (produce & consume) with this change on top of the 4.0 branch. Reviewers: David Arthur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing, we identified that kafka-python (and aiokafka) relies on metadata request v0 and
hence we need to add these back to comply with the premise of KIP-896 - i.e. it should not
break the clients listed within it.
I reverted the changes from #18218 related to the removal of metadata versions 0-3.
I will submit a separate PR to undeprecate these API versions on the relevant 3.x branches.
kafka-python (and aiokafka) work correctly (produce & consume) with this change on
top of the 4.0 branch.
Committer Checklist (excluded from commit message)