Skip to content

KAFKA-18334: Produce v4-v6 should be undeprecated#18288

Merged
ijuma merged 2 commits intoapache:trunkfrom
ijuma:kafka-14560-produce-v4-v6-undeprecated
Dec 21, 2024
Merged

KAFKA-18334: Produce v4-v6 should be undeprecated#18288
ijuma merged 2 commits intoapache:trunkfrom
ijuma:kafka-14560-produce-v4-v6-undeprecated

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Dec 20, 2024

Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.
Copy link
Copy Markdown
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the core Kafka Broker label Dec 20, 2024
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Dec 21, 2024

Test failures are flaky and unrelated. Ran them locally and they passed.

@ijuma ijuma merged commit 288d4de into apache:trunk Dec 21, 2024
@ijuma ijuma deleted the kafka-14560-produce-v4-v6-undeprecated branch December 21, 2024 01:21
ijuma added a commit to ijuma/kafka that referenced this pull request Dec 21, 2024
…e-old-protocol-versions

* apache-github/trunk:
  KAFKA-18334: Produce v4-v6 should be undeprecated (apache#18288)
  KAFKA-13722: code cleanup after deprecated StateStore.init() was removed (apache#18249)
  KAFKA-15370: Support Participation in 2PC (KIP-939) (1/N) (apache#17687)
ijuma added a commit that referenced this pull request Dec 21, 2024
Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.

Reviewers: David Arthur <[email protected]>
ijuma added a commit that referenced this pull request Dec 21, 2024
Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.

Reviewers: David Arthur <[email protected]>
ijuma added a commit that referenced this pull request Dec 21, 2024
Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.

Reviewers: David Arthur <[email protected]>
ijuma added a commit that referenced this pull request Dec 21, 2024
Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.

Reviewers: David Arthur <[email protected]>
@github-actions github-actions Bot removed the triage PRs from the community label Dec 21, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.

Reviewers: David Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients core Kafka Broker small Small PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants