Skip to content

KAFKA-13722: code cleanup after deprecated StateStore.init() was removed#18249

Merged
mjsax merged 4 commits intoapache:trunkfrom
mjsax:kafka-13722-processorcontext-casts
Dec 20, 2024
Merged

KAFKA-13722: code cleanup after deprecated StateStore.init() was removed#18249
mjsax merged 4 commits intoapache:trunkfrom
mjsax:kafka-13722-processorcontext-casts

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Dec 18, 2024

We remove the deprecated overload of StateStore.init() and thus do not need to cast any longer. This PR removes all unnecessary casts, and additionally cleans ups all related classed to reduce warnings.

@mjsax mjsax added the streams label Dec 18, 2024
@mjsax mjsax force-pushed the kafka-13722-processorcontext-casts branch from 1551fa4 to 6e56809 Compare December 19, 2024 01:56
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

Java 17 passed.

Java 23:

FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer
Found 1 flaky test failures:
FLAKY ⚠️  TransactionsTest > testFailureToFenceEpoch(String, String, boolean).quorum=kraft.groupProtocol=classic.isTV2Enabled=true

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 20, 2024

Java 23:

Found 1 test failures:
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer

We remove the deprecated overload of StateStore.init() and thus do not
need to cast any longer. This PR removes all unnecessary casts, and
additionally cleans ups all related classed to reduce warnings.
@mjsax mjsax force-pushed the kafka-13722-processorcontext-casts branch from fc22fb3 to bee2de5 Compare December 20, 2024 07:08
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 20, 2024

Java 17 passed.

Java 23:

Found 3 test failures:
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroups(String, String).quorum=kraft.groupProtocol=consumer
FAILED ❌ UserClientIdQuotaTest > testThrottledRequest(String, String).quorum=kraft.groupProtocol=consumer
Found 1 flaky test failures:
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceived()

@mjsax mjsax merged commit 8c21857 into apache:trunk Dec 20, 2024
@mjsax mjsax deleted the kafka-13722-processorcontext-casts branch December 20, 2024 22:51
mjsax added a commit that referenced this pull request Dec 20, 2024
…ved (#18249)

We remove the deprecated overload of StateStore.init() and thus do not
need to cast any longer. This PR removes all unnecessary casts, and
additionally cleans ups all related classed to reduce warnings.

Reviewers: Bill Bejeck <[email protected]>
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 20, 2024

Merged to trunk and cherry-picked to 4.0 branch.

ijuma added a commit to ijuma/kafka that referenced this pull request Dec 21, 2024
…e-old-protocol-versions

* apache-github/trunk:
  KAFKA-18334: Produce v4-v6 should be undeprecated (apache#18288)
  KAFKA-13722: code cleanup after deprecated StateStore.init() was removed (apache#18249)
  KAFKA-15370: Support Participation in 2PC (KIP-939) (1/N) (apache#17687)
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
…ved (apache#18249)

We remove the deprecated overload of StateStore.init() and thus do not
need to cast any longer. This PR removes all unnecessary casts, and
additionally cleans ups all related classed to reduce warnings.

Reviewers: Bill Bejeck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants