KAFKA-13722: Refactor SerdeGetter#18242
Merged
chia7712 merged 2 commits intoapache:trunkfrom Dec 18, 2024
Merged
Conversation
Refactor SerdeGetter to not use old ProcessorContext any longer.
chia7712
approved these changes
Dec 18, 2024
| newProcessorContext != null ? newProcessorContext.valueSerde() : stateStorecontext.valueSerde(); | ||
|
|
||
| public Serde<?> valueSerde() { | ||
| return processorContext != null ? processorContext.valueSerde() : stateStorecontext.valueSerde(); |
Member
There was a problem hiding this comment.
The IDE incorrectly assumes that stateStoreContext.valueSerde() might throw a NPE. To eliminate this false alert, perhaps we can retain the Supplier<Serde<?>> instead.
private final Supplier<Serde<?>> keySerdeSupplier;
private final Supplier<Serde<?>> valueSerdeSupplier;
public SerdeGetter(final ProcessorContext<?, ?> context) {
keySerdeSupplier = context::keySerde;
valueSerdeSupplier = context::valueSerde;
}
public SerdeGetter(final StateStoreContext context) {
keySerdeSupplier = context::keySerde;
valueSerdeSupplier = context::valueSerde;
}
public Serde<?> keySerde() {
return keySerdeSupplier.get();
}
public Serde<?> valueSerde() {
return valueSerdeSupplier.get();
}
cadonna
approved these changes
Dec 18, 2024
| newProcessorContext != null ? newProcessorContext.valueSerde() : stateStorecontext.valueSerde(); | ||
|
|
||
| public Serde<?> valueSerde() { | ||
| return processorContext != null ? processorContext.valueSerde() : stateStorecontext.valueSerde(); |
Member
Author
|
Java 23: |
Member
Author
|
Java 17: |
Member
|
testThrottledProducerConsumer -> https://issues.apache.org/jira/browse/KAFKA-8073 |
mjsax
added a commit
that referenced
this pull request
Dec 19, 2024
Reviewers: Bruno Cadonna <[email protected]>, Chia-Ping Tsai <[email protected]>
Member
Author
|
Cherry-picked to |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 19, 2024
…e-old-protocol-versions * apache-github/trunk: (25 commits) KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (apache#18262) KAFKA-18284: Add group coordinator records for Streams rebalance protocol (apache#18228) MINOR: Fix flaky state updater test (apache#18253) MINOR: improve StreamsResetter logging (apache#18237) KAFKA-18227: Ensure v2 partitions are not added to last transaction during upgrade (apache#18176) Add IT for share consumer with duration base offet auto reset (apache#18251) KAFKA-18283: Add StreamsGroupDescribe RPC definitions (apache#18230) KAFKA-18241: add docs check to CI (apache#18183) KAFKA-18223 Improve flaky test report (apache#18212) MINOR Remove triage label in nightly job (apache#18147) KAFKA-18294 Remove deprecated SourceTask#commitRecord (apache#18260) KAFKA-18264 Remove NotLeaderForPartitionException (apache#18211) KAFKA-13722: Refactor SerdeGetter (apache#18242) KAFKA-18094 Remove deprecated TopicListing(String, Boolean) (apache#18248) KAFKA-18282: Add StreamsGroupHeartbeat RPC definitions (apache#18227) KAFKA-18026: KIP-1112 migrate KTableSuppressProcessorSupplier (apache#18150) KAFKA-18026: transition KTable#filter impl to use processor wrapper (apache#18205) KAFKA-18293 Remove `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerLoginCallbackHandler` and `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler` (apache#18244) MINOR: add assertion about groupEpoch and targetAssignmentEpoch to testConsumerGroups (apache#18203) KAFKA-17960; PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol (apache#18234) ...
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Reviewers: Bruno Cadonna <[email protected]>, Chia-Ping Tsai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SerdeGetter to not use old ProcessorContext any longer.