Skip to content

KAFKA-15738: Adding KRaft support in ConsumerWithLegacyMessageFormatIntegrationTest#15171

Merged
omkreddy merged 2 commits intoapache:trunkfrom
adixitconfluent:kafka-15738_fix
Jan 12, 2024
Merged

KAFKA-15738: Adding KRaft support in ConsumerWithLegacyMessageFormatIntegrationTest#15171
omkreddy merged 2 commits intoapache:trunkfrom
adixitconfluent:kafka-15738_fix

Conversation

@adixitconfluent
Copy link
Copy Markdown
Contributor

@adixitconfluent adixitconfluent commented Jan 11, 2024

About
This PR adds KRaft support to the following tests in ConsumerWithLegacyMessageFormatIntegrationTest class -

  1. testOffsetsForTimes
  2. testEarliestOrLatestOffsets

reference - KAFKA-15738

Testing
Adding screenhots confirming the tests are passing on CLI for ConsumerWithLegacyMessageFormatIntegrationTest
Screenshot 2024-01-11 at 2 05 49 PM

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@adixitconfluent
Copy link
Copy Markdown
Contributor Author

adixitconfluent commented Jan 11, 2024

As represented by the CLI screenshot in the PR description, the tests changed are passing. However the build is failing. Adding a screenshot of no new test failures from build. I can confirm the 2 tests testOffsetsForTimes
testEarliestOrLatestOffsets I have changed are not a part of failing tests in build https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15171/4/tests/
Screenshot 2024-01-11 at 9 01 59 PM

Copy link
Copy Markdown
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adixitconfluent Thanks for the PR. LGTM

@omkreddy omkreddy merged commit 8cdf1ab into apache:trunk Jan 12, 2024
showuon pushed a commit to showuon/kafka that referenced this pull request Jan 22, 2024
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants