MINOR; Use underscore for variable initialization in BrokerServer#12471
Merged
mimaison merged 1 commit intoapache:trunkfrom Aug 18, 2022
Merged
Conversation
Member
|
Thank you for the review. Looks good. One question though (which does not have to be addressed part of this PR), do we have a linter for scala that can enforce such best practices? |
divijvaidya
approved these changes
Aug 2, 2022
Contributor
Author
|
Yes there is, its called scalafix, would just have to integrate it into gradle. There is also scalafmt which works on the context free grammar linting fixes, I noticed there is a configuration for this already in Kafka but for some reason Gradle build doesn't use it (or at least it doesn't fail if there is a formatting error). |
3 tasks
In Scala its standard practice to use _ whenever you are initializing variables. In regards to implementation, for object references _ initialization maps to null so there is no chance in behaviour.
mdedetrich
force-pushed
the
brokerserver-underscore-initialization
branch
from
c14683a to
f57893d
Compare
mimaison
approved these changes
Aug 18, 2022
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Scala its standard practice to use _ whenever you are initializing
variables. In regards to implementation, for object references
_ initialization maps to null so there is no chance in behaviour.
Committer Checklist (excluded from commit message)