Skip to content

KAFKA-13035 updated documentation for connector restart REST API to …#10975

Merged
rhauch merged 2 commits into
apache:trunkfrom
kpatelatwork:KAFKA-13035
Jul 6, 2021
Merged

KAFKA-13035 updated documentation for connector restart REST API to …#10975
rhauch merged 2 commits into
apache:trunkfrom
kpatelatwork:KAFKA-13035

Conversation

@kpatelatwork

Copy link
Copy Markdown
Contributor

…include the tasks restart behavior

Targets AK 3.0.0 where KAFKA-4793 will get released.

@kkonstantine and @rhauch Could you please review and see if the changes look good.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kpatelatwork

Copy link
Copy Markdown
Contributor Author

This is how formatting looks locally
image

@showuon showuon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@rhauch rhauch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kpatelatwork. A minor suggestion to mention how this feature by default preserves the same behavior as earlier versions.

Comment thread docs/connect.html Outdated
Comment thread docs/connect.html Outdated
@kpatelatwork

Copy link
Copy Markdown
Contributor Author

@rhauch great call about the backward compatibility note, I applied the suggestions. When you get time, could you please check again if it looks good?

@rhauch rhauch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @kpatelatwork!

@rhauch rhauch merged commit 2e89f40 into apache:trunk Jul 6, 2021
kkonstantine pushed a commit that referenced this pull request Jul 6, 2021
…#10975)

Updated documentation for connector restart REST API to include the tasks restart behavior, including calling out that by default the same behavior of previous versions is preserved.

Author: Kalpesh Patel <[email protected]>
Reviewer: Randall Hauch <[email protected]>
xdgrulez pushed a commit to xdgrulez/kafka that referenced this pull request Dec 22, 2021
…apache#10975)

Updated documentation for connector restart REST API to include the tasks restart behavior, including calling out that by default the same behavior of previous versions is preserved.

Author: Kalpesh Patel <[email protected]>
Reviewer: Randall Hauch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants