Add a multiplier to avoid receiver OOM in IoTConsensus #16102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTHou
approved these changes
Aug 5, 2025
|
jt2594838
added a commit
that referenced
this pull request
Nov 26, 2025
jt2594838
added a commit
that referenced
this pull request
Nov 27, 2025
…6812) * more accurate mermory size (#15713) * Fix stuck when stopping a DataNode with large unremovable WAL files (#15727) * Fix stuck when stopping a DataNode with large unremovable WAL files * spotless * add shutdown hook watcher * Fix logDispatcher stuck * add re-interrupt * Add a multiplier to avoid receiver OOM in IoTConsensus (#16102) * Fix negative iot queue size & missing search index for deletion & missed request when performing empty table deleting (#16022) * Fix double memory free of iotconsensus queue request during region deletion * Fix missing searchIndex and lost deletion when no TsFile is involved. * Fix ref count of IoTConsensus request not decreased in allocation failure (#16169) * fix IoTConsensus memory management * Fix ref count of IoTConsensus request not decreased in allocation failure * fix log level * remove irrelevant codes from 2.0 * Remove a table test * Interrupt wal-delete thread when WALManager is closed (#15442) --------- Co-authored-by: Xiangpeng Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the WAL to construct a log batch in IoTConsensus, the memory control of the batch is based on the size of serialized entries, which can be significantly smaller than the memory size of PlanNodes.
Therefore, when the receiver deserializes the log batch, the memory footprint may be times larger than it was on the sender, and this could lead to OOM.
To avoid this, the receiver now returns its memory cost after deserializing the batch to the sender, so that the sender can adjust the subsequent batch size accordingly.