Fix negative iot queue size & missing search index for deletion & missed request when performing empty table deleting #16022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16022 +/- ##
============================================
- Coverage 39.01% 39.01% -0.01%
Complexity 198 198
============================================
Files 4848 4848
Lines 316085 316076 -9
Branches 39807 39816 +9
============================================
- Hits 123335 123324 -11
- Misses 192750 192752 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HTHou
approved these changes
Jul 25, 2025
jt2594838
added a commit
that referenced
this pull request
Nov 26, 2025
…sed request when performing empty table deleting (#16022) * Fix double memory free of iotconsensus queue request during region deletion * Fix missing searchIndex and lost deletion when no TsFile is involved.
jt2594838
added a commit
that referenced
this pull request
Nov 27, 2025
…6812) * more accurate mermory size (#15713) * Fix stuck when stopping a DataNode with large unremovable WAL files (#15727) * Fix stuck when stopping a DataNode with large unremovable WAL files * spotless * add shutdown hook watcher * Fix logDispatcher stuck * add re-interrupt * Add a multiplier to avoid receiver OOM in IoTConsensus (#16102) * Fix negative iot queue size & missing search index for deletion & missed request when performing empty table deleting (#16022) * Fix double memory free of iotconsensus queue request during region deletion * Fix missing searchIndex and lost deletion when no TsFile is involved. * Fix ref count of IoTConsensus request not decreased in allocation failure (#16169) * fix IoTConsensus memory management * Fix ref count of IoTConsensus request not decreased in allocation failure * fix log level * remove irrelevant codes from 2.0 * Remove a table test * Interrupt wal-delete thread when WALManager is closed (#15442) --------- Co-authored-by: Xiangpeng Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 issues:
When removing a region of IoTConsensus, its LogDispatcher will be interrupted. Before the LogDispatcher exits, the thread that handles the removal will wait for at most 30 seconds to release resources. Therefore, when the wait timeouts, both the LogDispatcher thread and the region removal thread may release the same resource. As a result, memory allocated for IoT requests may be freed twice, leading to a negative memory size in the metric.
Reference count is introduced to avoid memory from being freed twice.
The IoTConsensus may merge several deletions with the same pattern or time range into one. During the process, the merge result will lose its search index.
If a table deletion involves no TsFile, it will not be written to any WAL and cannot be sent by the IoTConsensus.