Skip to content

[To dev/1.3] Enhance "remove region" sql to handle the case of DataNode not exist #15744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyuheng55555 merged 2 commits into from
Jun 17, 2025
Merged

[To dev/1.3] Enhance "remove region" sql to handle the case of DataNode not exist #15744

liyuheng55555 merged 2 commits into from
Jun 17, 2025

Conversation

@CRZbulabula
Copy link
Contributor

@CRZbulabula CRZbulabula commented Jun 17, 2025 •
edited by liyuheng55555
Loading

cp #15728

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

liyuheng55555
liyuheng55555 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@liyuheng55555 liyuheng55555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 41.14%. Comparing base (0dd2f8c) to head (920d5de).
Report is 1 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...che/iotdb/confignode/manager/ProcedureManager.java 0.00% 18 Missing ⚠️
.../persistence/partition/DatabasePartitionTable.java 0.00% 5 Missing ⚠️
.../confignode/persistence/partition/RegionGroup.java 0.00% 3 Missing ⚠️
...onfignode/persistence/partition/PartitionInfo.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             dev/1.3   #15744   +/-   ##
==========================================
  Coverage      41.14%   41.14%           
  Complexity       198      198           
==========================================
  Files           3568     3568           
  Lines         231727   231744   +17     
  Branches       27664    27665    +1     
==========================================
+ Hits           95336    95355   +19     
+ Misses        136391   136389    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liyuheng55555 liyuheng55555 merged commit d799098 into dev/1.3 Jun 17, 2025
26 of 28 checks passed
JackieTien97 pushed a commit that referenced this pull request Sep 1, 2025
@CRZbulabula @liyuheng55555 @JackieTien97
[To dev/1.3] Enhance "remove region" sql to handle the case of DataNo…
4b9df07 
…de not exist (#15744)

* Enhance "remove region" sql to handle the case of DataNode not exist (#15728)

* finish

---------

Co-authored-by: Li Yu Heng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liyuheng55555 liyuheng55555 liyuheng55555 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CRZbulabula @liyuheng55555