Load: Enhanced the table auto-creation logic #15265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the auto-creation logic for loading TS files by refactoring the auto-creation and verification processes and integrating database/table auto-creation into the load workflow. Key changes include:
- Refactoring of auto-deletion and auto-creation logic in ModificationUtils and LoadTsFileTableSchemaCache.
- Removal of duplicate database creation logic in LoadTsFileAnalyzer and updates to schema cache handling.
- Addition of new integration tests in IoTDBPipeWithLoadIT to validate behavior when tables are deleted or missing insert permissions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java | Updates the device deletion check logic, transitioning from Optional to Objects-based null checks. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java | Removes explicit initializations for several flags and thresholds, relying on Java defaults. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileTableSchemaCache.java | Introduces new fields and methods to support auto-creation of databases and manages table schema mappings. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileAnalyzer.java | Refactors schema cache utilization and removes redundant database creation logic. |
| integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/tablemodel/manual/basic/IoTDBPipeWithLoadIT.java | Adds integration tests for scenarios involving auto-creation with table deletion and permission issues. |
Comments suppressed due to low confidence (1)
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java:44
- Removal of explicit default values for fields (e.g., deleteAfterLoad, convertOnTypeMismatch, tabletConversionThresholdBytes, autoCreateDatabase, verify) may unintentionally change their default behavior. Confirm that relying on Java’s default values is intentional compared to the previous explicit initialization.
private boolean deleteAfterLoad;
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java
Outdated
Show resolved
Hide resolved
…dificationUtils.java Co-authored-by: Copilot <[email protected]>
Caideyipi
changed the title
Caideyipi
force-pushed
the
tree-verifier-fix
branch
from
b8b393d to
2b03d4c
Compare
Caideyipi
changed the title
SteveYurongSu
changed the title
DanielWang2035
approved these changes
Apr 23, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java
Show resolved
Hide resolved
SteveYurongSu
approved these changes
Apr 23, 2025
SteveYurongSu
added a commit
that referenced
this pull request
Apr 24, 2025
This reverts commit 8eb73e0.
SteveYurongSu
added a commit
that referenced
this pull request
Apr 24, 2025
This reverts commit 6b20d82.
11 tasks
SteveYurongSu
pushed a commit
that referenced
this pull request
May 8, 2025
JackieTien97
pushed a commit
that referenced
this pull request
May 14, 2025
(cherry picked from commit 8eb73e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR