Skip to content

[INLONG-8922][Sort] Add TubeMQ source and sink connector on flink 1.15 #9031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EMsnap merged 12 commits into from
Oct 16, 2023
Merged

[INLONG-8922][Sort] Add TubeMQ source and sink connector on flink 1.15 #9031

EMsnap merged 12 commits into from
Oct 16, 2023

Conversation

@fancycoderzf
Copy link
Contributor

@fancycoderzf fancycoderzf commented Oct 8, 2023 •
edited
Loading

Prepare a Pull Request

Motivation

Add TubeMQ source and sink connector on flink 1.15.

Modifications

Add TubeMQ source and sink connector on flink 1.15.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

#####################################################################################################
I have some trouble to write the end-to-end test for TubeMQ. So I just run some tests in local and flink(v1.15) bin/sql-client.sh. I will consider adding end-to-end testing.
image

image

@fancycoderzf fancycoderzf changed the title [Feature][Sort] Add TubeMQ source and sink connector on flink 1.15 [INLONG-8922][Sort] Add TubeMQ source and sink connector on flink 1.15 Oct 8, 2023
EMsnap
EMsnap reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests about this pr thanks

@fancycoderzf fancycoderzf mentioned this pull request Oct 16, 2023
Merged
EMsnap
EMsnap approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMsnap EMsnap merged commit 12e1a46 into apache:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

@vernedeng vernedeng vernedeng approved these changes

Assignees

No one assigned

Labels

component/sort

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Add TubeMQ connector on flink 1.15

4 participants

@fancycoderzf @dockerzhang @EMsnap @vernedeng