[INLONG-8358][Sort] Add kafka connector on flink 1.15 #8713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrainll
force-pushed
the
INLONG-8358
branch
from
759516a to
c06aa51
Compare
EMsnap
reviewed
Sep 18, 2023
Member
EMsnap
left a comment
EMsnap
left a comment
There was a problem hiding this comment.
Please add a end to end test under sort-end-to-end-tests to test the code thx ~
Contributor
Author
ok |
Contributor
|
@hnrainll please fix the conflicts, thanks. |
Contributor
Author
OK |
hnrainll
force-pushed
the
INLONG-8358
branch
2 times, most recently
from
095ca3c to
a2d54ed
Compare
hnrainll
force-pushed
the
INLONG-8358
branch
from
421cc85 to
29154a6
Compare
Member
|
Sorry but there should be UT for this feature, any problem with implementing it ? |
Contributor
Author
No problem, I'm in the process of implementing UT's functionality. |
hnrainll
force-pushed
the
INLONG-8358
branch
2 times, most recently
from
6b2f47b to
a106ef8
Compare
healchow
previously approved these changes
Dec 6, 2023
EMsnap
reviewed
Dec 6, 2023
...s/sort-end-to-end-tests-v1.15/src/test/java/org/apache/inlong/sort/tests/KafkaE2EITCase.java
Outdated
Show resolved
Hide resolved
vernedeng
approved these changes
Dec 12, 2023
healchow
approved these changes
Dec 12, 2023
e-mhui
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Add kafka connector on flink 1.15
Modifications
Add kafka connector on flink 1.15