[INLONG-7056][Sort] Adjust sort resources according to data scale #10916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
changed the title
aloyszhang
reviewed
Aug 28, 2024
inlong-manager/manager-plugins/base/src/main/resources/flink-sort-plugin.properties
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
inlong-manager/manager-plugins/base/src/main/resources/flink-sort-plugin.properties
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
...nager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/enums/Constants.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
...nager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/dto/FlinkConfig.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
inlong-audit/audit-common/src/main/java/org/apache/inlong/audit/consts/OpenApiConstants.java
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
.../manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkService.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 28, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Show resolved
Hide resolved
aloyszhang
reviewed
Aug 29, 2024
inlong-manager/manager-plugins/base/src/main/resources/flink-sort-plugin.properties
Outdated
Show resolved
Hide resolved
Contributor
|
@fuweng11 There are some modifications in the manager module, PTAL |
aloyszhang
previously approved these changes
Aug 30, 2024
fuweng11
reviewed
Aug 30, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
fuweng11
reviewed
Aug 30, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Show resolved
Hide resolved
fuweng11
reviewed
Aug 30, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
Contributor
|
When a group is a real-time synchronization task, there is no dataproxy present. How to handle this situation.Is there a default value when dataproxy does not exist？ |
fuweng11
reviewed
Aug 30, 2024
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
...ins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkParallelismOptimizer.java
Outdated
Show resolved
Hide resolved
Contributor
Author
When no audit data of DataProxy is present, the |
Contributor
Author
Demo of adjusting parallelism is shown in the picture. (Failure is caused by resource limitation of my computer) |
fuweng11
reviewed
Aug 30, 2024
.../manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkService.java
Show resolved
Hide resolved
fuweng11
approved these changes
Aug 30, 2024
vernedeng
approved these changes
Aug 30, 2024
dockerzhang
approved these changes
Aug 31, 2024
MOONSakura0614
pushed a commit
to MOONSakura0614/inlong
that referenced
this pull request
Sep 3, 2024
wohainilaodou
pushed a commit
to wohainilaodou/inlong
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7056
Motivation
Currently, the total amount of resources for the Flink Sort Job comes from the configuration file
flink-sort-plugin.properties, meaning that all submitted sort jobs will use the same amount of resources. When the data scale is large, the resources may be insufficient, and when the data scale is small, the resources may be wasted. Therefore, dynamically adjusting the number of resources according to the amount of data is a critically needed function.Modifications
org.apache.inlong.manager.plugin.flink.FlinkService#submitJobBySavepoint, theorg.apache.inlong.manager.plugin.flink.FlinkParallelismOptimizerwill first query the average data volume of from the past hour of theDataProxymodule and adjust the parallelism based on this data volume.flink-sort-plugin.propertiesOpenApiConstantstoorg.apache.inlong.audit.constsVerifying this change
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
When creating a stream in Data Ingestion, you can try to make the source data constantly increase and reach a significant amount (approximately more than 2000 per second). Then, resubmit the job. You should notice that the parallelism of the Flink job corresponding to the stream will be larger than the default value of 1. This change will also be reflected in the manager logs.
[] This change added tests and can be verified as follows: