Skip to content

add tcort/github-action-markdown-link-check#368

Merged
dfoulks1 merged 2 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/add-tcort/github-action-markdown-link-check
Nov 17, 2025
Merged

add tcort/github-action-markdown-link-check#368
dfoulks1 merged 2 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/add-tcort/github-action-markdown-link-check

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Nov 11, 2025

Request for adding a new GitHub Action to the allow list

Overview

Name of action: tcort/github-action-markdown-link-check

URL of action: https://github.com/tcort/github-action-markdown-link-check

Version to pin to (hash only): f3d33029dca1c4a24b87e2df648f9f4604ef6533

Relates to https://issues.apache.org/jira/browse/INFRA-27388

Permissions

Related Actions

An actively maintained fork of https://github.com/gaurav-nelson/github-action-markdown-link-check which is already allowlisted here

Checklist

You should be able to check most of these boxes for an action to be considered for review.
Please check all boxes that currently apply:

  • The action is listed in the GitHub Actions Marketplace
  • The action is not already on the list of approved actions
  • The action has a sufficient number of contributors or has contributors within the ASF community
  • The action has a clearly defined license
  • The action is actively developed or maintained
  • The action has CI/unit tests configured

Signed-off-by: Kevin Liu <[email protected]>
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (relevant) difference to the approved gaurav-nelson/github-action-markdown-link-check (latest 1.0.17) is the included markdown-checker version bump. I don't see anything suspicious in that diff.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, should we also expire gaurav-nelson/github-action-markdown-link-check and list this as recommended replacement?

@snazy
Copy link
Member

snazy commented Nov 14, 2025

sounds good, should we also expire gaurav-nelson/github-action-markdown-link-check and list this as recommended replacement?

WFM. I see these projects using it:
apache/flink-cdc
apache/fory-site
apache/incubator-pegasus
apache/linkis
apache/polaris
apache/skywalking-python

Already created apache/polaris#3058 for Polaris

@kevinjqliu
Copy link
Contributor Author

thank you both for the review. i created a tracking issue to migrate the relevant apache projects #371

@BaseMax
Copy link

BaseMax commented Nov 14, 2025

Hi all, I'm one of the maintainers of the markdown-link-check project.
If there's anything I can assist with during the migration or review process, please let me know. Glad to help anytime!

@dfoulks1 dfoulks1 merged commit 131aacd into apache:main Nov 17, 2025
5 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/add-tcort/github-action-markdown-link-check branch November 17, 2025 16:24
@kevinjqliu
Copy link
Contributor Author

btw this requires pin to a hash

    - uses: tcort/github-action-markdown-link-check@f3d33029dca1c4a24b87e2df648f9f4604ef6533

For example,
https://github.com/apache/iceberg-python/pull/2765/files#diff-181119b2f40cd521db4d958055bab125d9ff47293b7454e0e5967402c4d7106fR40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants