optimize: optimize druid 1.2.12 ci #7536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Jul 14, 2025
| // Unit test triggered a bug in Druid, see the issue https://github.com/alibaba/druid/issues/4936 | ||
| String skipTests = System.getProperty("skip_druid_tests", "true"); | ||
| return Boolean.parseBoolean(skipTests); | ||
| String enable = System.getenv("ENABLE_DRUID_TEST"); |
Contributor
There was a problem hiding this comment.
You should use @EnabledIfSystemProperty(named = "druid.version", matches = "1.2.12") to skip the unit test.
Contributor
Author
There was a problem hiding this comment.
I have modified, and my local ci had passed
funky-eyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
opt: optimize druid 1.2.12 ci. The previous pr had the wrong way of getting the environment variables
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews