optimize: avoid using unstable API in ChannelEventHandlerIntegrationTest #7518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2025 15:38
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7518 +/- ##
============================================
- Coverage 60.42% 60.40% -0.02%
+ Complexity 662 658 -4
============================================
Files 1298 1298
Lines 49080 49080
Branches 5770 5770
============================================
- Hits 29655 29647 -8
- Misses 16790 16802 +12
+ Partials 2635 2631 -4 see 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
slievrly
added a commit
that referenced
this pull request
Jul 11, 2025
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
After my research on the error, I found that it cannot be compiled on macOS 14, and the error "cannot find symbol: method registeredChannelsIterator()" is reported. The main reason is that the unstable API (@UnstableApi) in netty is used, specifically eventLoop.registeredChannelsIterator() in collectServerChannels.
My solution:
Avoid using unstable APIs, remove the original collectServerChannels, and refactor the testChannelInactiveByServer() method.
Results:
The code should be able to compile normally on macOS
All event handling of ChannelEventHandler is tested
The test logic is simplified, cross-platform compatibility is improved, and each test method does not affect each other
Ⅱ. Does this pull request fix one issue?
fixes #7510
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
mvn clean test
Ⅴ. Special notes for reviews