-
Notifications
You must be signed in to change notification settings - Fork 8.9k
test: add unit test case for fury serializer #7501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7501 +/- ##
============================================
- Coverage 60.38% 60.35% -0.03%
Complexity 658 658
============================================
Files 1284 1284
Lines 48465 48465
Branches 5694 5694
============================================
- Hits 29264 29253 -11
- Misses 16587 16598 +11
Partials 2614 2614 🚀 New features to boost your workflow:
|
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-serializer-fury: The following files had format violations:
Error: src/test/java/org/apache/seata/serializer/fury/FurySerializerTest.java
Error: @@ -92,7 +92,8 @@
Error: ················.withRefTracking(true)
Error: ················.withCompatibleMode(CompatibleMode.COMPATIBLE)
Error: ················.build();
Error: -········Assertions.assertThrows(DeserializationException.class,·()·->·furySerializer.deserialize(fury.serialize(testUnSafeSerializer)));
Error: +········Assertions.assertThrows(
Error: +················DeserializationException.class,·()·->·furySerializer.deserialize(fury.serialize(testUnSafeSerializer)));
Error: ····}
Error:
Error: ····@test
Error: Run 'mvn spotless:apply' to fix these violations.
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn -rf :seata-serializer-fury
Error: Process completed with exit code 1.
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add unit test case for fury serializer
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews