Skip to content

Conversation

@GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Jul 6, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add unit test case for fury serializer

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.35%. Comparing base (d2a18ae) to head (6775873).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7501      +/-   ##
============================================
- Coverage     60.38%   60.35%   -0.03%     
  Complexity      658      658              
============================================
  Files          1284     1284              
  Lines         48465    48465              
  Branches       5694     5694              
============================================
- Hits          29264    29253      -11     
- Misses        16587    16598      +11     
  Partials       2614     2614              

see 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-serializer-fury: The following files had format violations:
Error: src/test/java/org/apache/seata/serializer/fury/FurySerializerTest.java
Error: @@ -92,7 +92,8 @@
Error: ················.withRefTracking(true)
Error: ················.withCompatibleMode(CompatibleMode.COMPATIBLE)
Error: ················.build();
Error: -········Assertions.assertThrows(DeserializationException.class,·()·->·furySerializer.deserialize(fury.serialize(testUnSafeSerializer)));
Error: +········Assertions.assertThrows(
Error: +················DeserializationException.class,·()·->·furySerializer.deserialize(fury.serialize(testUnSafeSerializer)));
Error: ····}
Error:
Error: ····@test
Error: Run 'mvn spotless:apply' to fix these violations.
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn -rf :seata-serializer-fury
Error: Process completed with exit code 1.

@funky-eyes funky-eyes added this to the 2.5.0 milestone Jul 7, 2025
@funky-eyes funky-eyes added module/test test module module/serializer serializer module type: test test case and removed module/test test module labels Jul 7, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit a948dc7 into apache:2.x Jul 7, 2025
10 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/serializer serializer module type: test test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants