optimize: optimize fury deserialization #7498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7498 +/- ##
============================================
+ Coverage 60.34% 60.37% +0.03%
Complexity 658 658
============================================
Files 1284 1284
Lines 48465 48465
Branches 5694 5694
============================================
+ Hits 29247 29262 +15
+ Misses 16600 16586 -14
+ Partials 2618 2617 -1
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
slievrly
changed the title
slievrly
changed the title
pjfanning
reviewed
Jul 5, 2025
| SerializerSecurityRegistry.getAllowClassPattern().contains(className)); | ||
| AllowListChecker checker = new AllowListChecker(AllowListChecker.CheckLevel.STRICT); | ||
| f.getClassResolver().setClassChecker(checker); | ||
| checker.allowClasses(SerializerSecurityRegistry.getAllowClassPattern()); |
Member
There was a problem hiding this comment.
Would it be possible to add some tests for this change? The existing test coverage missed the fact there was a bug and no new tests were added in the PR.
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
Open
2 tasks
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Fixed the class name whitelist check issue in fury deserialization
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews