optimize: metrics add retry status #7478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 27, 2025 11:54
# Conflicts: # metrics/seata-metrics-api/src/main/java/org/apache/seata/metrics/IdConstants.java # server/src/main/java/org/apache/seata/server/metrics/MeterIdConstants.java
funky-eyes
added
first-time contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7478 +/- ##
============================================
+ Coverage 60.30% 60.33% +0.03%
Complexity 658 658
============================================
Files 1281 1281
Lines 48281 48308 +27
Branches 5676 5676
============================================
+ Hits 29114 29146 +32
+ Misses 16557 16554 -3
+ Partials 2610 2608 -2
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
funky-eyes
changed the title
funky-eyes
reviewed
Jun 27, 2025
|
|
||
| String APP_ID_KEY = "applicationId"; | ||
|
|
||
| String TRANSACTION_ID_KEY = "transactionId"; |
Contributor
There was a problem hiding this comment.
ID is a non-enumerable variable and cannot be used as a Prometheus monitoring metric. Otherwise, it will cause Prometheus cache data to inflate infinitely, leading to full GC and ultimately application OOM.
Contributor
|
If you're using the DingTalk app, please send your DingTalk account to my email at |
Contributor
|
Run 'mvn spotless:apply' to fix these violations. |
Contributor
Author
done |
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.Server metrics add global retry statuses, including GlobalStatus.CommitRetrying, GlobalStatus.RollbackRetrying, and GlobalStatus.TimeoutRollbackRetrying.
2.The collected data for the above statuses now includes information on transactionId and transactionName.
Ⅱ. Does this pull request fix one issue?
fixes #7447
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews