-
Notifications
You must be signed in to change notification settings - Fork 8.9k
test: add UT for SupportSqlWhereMethod class #7468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7468 +/- ##
============================================
+ Coverage 60.30% 60.33% +0.03%
Complexity 658 658
============================================
Files 1281 1281
Lines 48281 48281
Branches 5676 5676
============================================
+ Hits 29114 29131 +17
+ Misses 16557 16540 -17
Partials 2610 2610 🚀 New features to boost your workflow:
|
YongGoose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
left some comments
...qlparser-druid/src/test/java/org/apache/seata/sqlparser/druid/SupportSqlWhereMethodTest.java
Show resolved
Hide resolved
...qlparser-druid/src/test/java/org/apache/seata/sqlparser/druid/SupportSqlWhereMethodTest.java
Show resolved
Hide resolved
|
If you have any further questions, please continue to point them out. @YongGoose ❤️ |
YongGoose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
|
PTAL @funky-eyes |
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add UT for SupportSqlWhereMethod class
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews