Skip to content

Conversation

@maple525866
Copy link
Contributor

@maple525866 maple525866 commented Jun 25, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add UT for SupportSqlWhereMethod class

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.33%. Comparing base (208c2cd) to head (1c77b4e).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7468      +/-   ##
============================================
+ Coverage     60.30%   60.33%   +0.03%     
  Complexity      658      658              
============================================
  Files          1281     1281              
  Lines         48281    48281              
  Branches       5676     5676              
============================================
+ Hits          29114    29131      +17     
+ Misses        16557    16540      -17     
  Partials       2610     2610              

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
left some comments

@maple525866
Copy link
Contributor Author

If you have any further questions, please continue to point them out. @YongGoose ❤️

Copy link
Member

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@maple525866
Copy link
Contributor Author

PTAL @funky-eyes

@YongGoose YongGoose requested a review from funky-eyes June 27, 2025 04:50
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 2e7eced into apache:2.x Jun 29, 2025
8 checks passed
@slievrly slievrly added this to the 2.5.0 milestone Jun 29, 2025
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants