Skip to content

Conversation

@YvCeung
Copy link
Contributor

@YvCeung YvCeung commented Jun 24, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

test:improve unit test coverage of seata-gRPC moudle

Ⅱ. Does this pull request fix one issue?

#fixes #7384

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

mvn clean test

Ⅴ. Special notes for reviews

before:
image

now:
image

During the process of reading the source code, I added some comments. Besides, I also found some unused variables, and then I deleted them.For example:
image

YvCeung added 3 commits June 24, 2025 17:58
# Conflicts:
#	integration/grpc/src/main/java/org/apache/seata/integration/grpc/interceptor/server/ServerListenerProxy.java
#	integration/grpc/src/main/java/org/apache/seata/integration/grpc/interceptor/server/ServerTransactionInterceptor.java
@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.30%. Comparing base (cbc6ac5) to head (291ba49).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7464      +/-   ##
============================================
+ Coverage     60.21%   60.30%   +0.08%     
  Complexity      658      658              
============================================
  Files          1281     1281              
  Lines         48282    48281       -1     
  Branches       5676     5676              
============================================
+ Hits          29075    29116      +41     
+ Misses        16602    16557      -45     
- Partials       2605     2608       +3     
Files with missing lines Coverage Δ
...n/grpc/interceptor/server/ServerListenerProxy.java 88.88% <ø> (+88.88%) ⬆️
...terceptor/server/ServerTransactionInterceptor.java 83.33% <ø> (+83.33%) ⬆️

... and 11 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@funky-eyes funky-eyes added this to the 2.5.0 milestone Jun 25, 2025
@funky-eyes funky-eyes added module/integration integration module type: test test case labels Jun 25, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 208c2cd into apache:2.x Jun 25, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung added a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/integration integration module type: test test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add UT for gRPC module

2 participants