Skip to content

Conversation

@funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

image
image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.5.0 milestone Jun 13, 2025
@funky-eyes funky-eyes added the type: test test case label Jun 13, 2025
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.x@22945a8). Learn more about missing BASE report.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@          Coverage Diff           @@
##             2.x    #7436   +/-   ##
======================================
  Coverage       ?   59.22%           
  Complexity     ?      548           
======================================
  Files          ?     1281           
  Lines          ?    46191           
  Branches       ?     5569           
======================================
  Hits           ?    27356           
  Misses         ?    16281           
  Partials       ?     2554           
Files with missing lines Coverage Δ
...ache/seata/namingserver/manager/NamingManager.java 69.68% <100.00%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 5164f9b into apache:2.x Jun 13, 2025
9 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants