Skip to content

test: Add common test config for dynamic server port assignment in tests #7435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 9 commits into from
Jun 13, 2025
Merged

test: Add common test config for dynamic server port assignment in tests #7435

funky-eyes merged 9 commits into from
Jun 13, 2025
+168 −12

Conversation

@YongGoose
Copy link
Member

@YongGoose YongGoose commented Jun 12, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@YongGoose YongGoose changed the title bug-fix: Add common test config for dynamic server port assignment in tests [WIP] Add common test config for dynamic server port assignment in tests Jun 12, 2025
@YongGoose YongGoose force-pushed the hot-fix/port-binding-issue branch from 6dc179a to c46d7db Compare June 12, 2025 14:54
@YongGoose YongGoose changed the title [WIP] Add common test config for dynamic server port assignment in tests test: Add common test config for dynamic server port assignment in tests Jun 12, 2025
@YongGoose
trigger ci
8660d13 
Signed-off-by: yongjunhong <[email protected]>
@YongGoose YongGoose force-pushed the hot-fix/port-binding-issue branch from 4f24cf4 to 8660d13 Compare June 12, 2025 14:56
YongGoose added 2 commits June 13, 2025 00:08
@YongGoose
Update config
a8ac70e 
Signed-off-by: yongjunhong <[email protected]>
@YongGoose
Update config
76b4d2b 
Signed-off-by: yongjunhong <[email protected]>
@YongGoose YongGoose force-pushed the hot-fix/port-binding-issue branch from 1a0bee0 to 76b4d2b Compare June 12, 2025 15:26
YongGoose added 2 commits June 13, 2025 00:30
@YongGoose
Update config
bf28d6e 
Signed-off-by: yongjunhong <[email protected]>
@YongGoose
Update config
6f27c78 
Signed-off-by: yongjunhong <[email protected]>
@codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.32%. Comparing base (bd717a6) to head (7b082d1).
Report is 2 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x    #7435      +/-   ##
============================================
- Coverage     58.62%   58.32%   -0.30%     
- Complexity      571      575       +4     
============================================
  Files          1269     1269              
  Lines         45730    45774      +44     
  Branches       5548     5555       +7     
============================================
- Hits          26807    26698     -109     
- Misses        16344    16508     +164     
+ Partials       2579     2568      -11

see 44 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

YongGoose added 2 commits June 13, 2025 00:50
@YongGoose
Update config
c7f7630 
Signed-off-by: yongjunhong <[email protected]>
@YongGoose
Update config
ed846ed 
Signed-off-by: yongjunhong <[email protected]>
@funky-eyes funky-eyes requested a review from Copilot June 13, 2025 07:08
Copilot AI reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a common test configuration enabling dynamic server port assignment in tests, ensuring that tests run on available ports instead of hard-coded ones. The key changes include:

  • Incorporation of a new DynamicPortTestConfig class to dynamically allocate ports.
  • Updates across multiple test files to import and use the DynamicPortTestConfig via @import annotations.

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/src/test/java/org/apache/seata/server/raft/execute/GlobalSessionExecuteTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/raft/execute/BranchSessionExecuteTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/raft/RaftSyncMessageTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/raft/RaftServerTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/logging/AppenderTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/redis/RedisLuaLockManagerTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/redis/RedisLockManagerTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/file/FileLockManagerImplTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/db/DataBaseLockStoreDAOTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/db/DataBaseLockManagerImplTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/LockManagerTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/lock/DistributedLockerFactoryTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/event/DefaultCoreForEventBusTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/coordinator/DefaultCoreTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/coordinator/DefaultCoordinatorTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/controller/VGroupMappingControllerTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/controller/ClusterControllerTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration; also commented out the TestPropertySource annotation.
server/src/test/java/org/apache/seata/server/ParameterParserTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/LoaderConfTest.java Added import and @import(DynamicPortTestConfig.class) for dynamic port configuration.
server/src/test/java/org/apache/seata/server/DynamicPortTestConfig.java New file providing dynamic port assignment for tests.

@funky-eyes funky-eyes added this to the 2.5.0 milestone Jun 13, 2025
@funky-eyes funky-eyes added module/server server module type: test test case labels Jun 13, 2025
xingfudeshi
xingfudeshi approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YongGoose
Update config
7b082d1 
Signed-off-by: yongjunhong <[email protected]>
@YongGoose
Copy link
Member Author

YongGoose commented Jun 13, 2025 

com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications link failure
The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at com.mysql.jdbc.Util.handleNewInstance(Util.java:425)
	at com.mysql.jdbc.SQLError.createCommunicationsException(SQLError.java:989)
	at com.mysql.jdbc.MysqlIO.<init>(MysqlIO.java:341)
	at com.mysql.jdbc.ConnectionImpl.coreConnect(ConnectionImpl.java:2192)
	at com.mysql.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:2225)
	at com.mysql.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:2024)
	at com.mysql.jdbc.ConnectionImpl.<init>(ConnectionImpl.java:779)
	at com.mysql.jdbc.JDBC4Connection.<init>(JDBC4Connection.java:47)
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at com.mysql.jdbc.Util.handleNewInstance(Util.java:425)
	at com.mysql.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:389)
	at com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:330)
	at com.alibaba.druid.pool.DruidAbstractDataSource.createPhysicalConnection(DruidAbstractDataSource.java:1703)
	at com.alibaba.druid.pool.DruidAbstractDataSource.createPhysicalConnection(DruidAbstractDataSource.java:1801)
	at com.alibaba.druid.pool.DruidDataSource$CreateConnectionThread.run(DruidDataSource.java:2946)
Caused by: java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.pollConnect(Native Method)
	at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682)
	at java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:578)
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:628)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
	at java.base/java.net.Socket.connect(Socket.java:759)
	at com.mysql.jdbc.StandardSocketFactory.connect(StandardSocketFactory.java:211)
	at com.mysql.jdbc.MysqlIO.<init>(MysqlIO.java:300)
	... 14 common frames omitted
 <==

funky-eyes
funky-eyes approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 16be18e into apache:2.x Jun 13, 2025
9 checks passed
@YongGoose YongGoose mentioned this pull request Jun 15, 2025
Closed
1 task
@WangzJi WangzJi mentioned this pull request Jun 23, 2025
Merged
1 task
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
@YongGoose
test: Add common test config for dynamic server port assignment in te…
824b509 
…sts (apache#7435)
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@YongGoose
test: Add common test config for dynamic server port assignment in te…
b2aa0cc 
…sts (apache#7435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@funky-eyes funky-eyes funky-eyes approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees

No one assigned

Labels

module/server server module type: test test case

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@YongGoose @funky-eyes @xingfudeshi