test: add UT for RemotingFactoryBeanParser class #7420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2025 15:34
maple525866
changed the title
YongGoose
added
first-time contributor
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive unit tests for the RemotingFactoryBeanParser class and updates module dependencies.
- Introduce
RemotingFactoryBeanParserTestwith cases covering constructor validation, proxy handling, reference/service checks, service descriptor retrieval, and protocol retrieval. - Add
seata-sqlparser-druidandmockito-inlinedependencies in the Spring module’s POM for parser integration and static mocking support.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spring/src/test/java/org/apache/seata/spring/remoting/parser/RemotingFactoryBeanParserTest.java | Add unit tests for all public behaviors of RemotingFactoryBeanParser. |
| spring/pom.xml | Add seata-sqlparser-druid and mockito-inline dependencies. |
Comments suppressed due to low confidence (3)
spring/src/test/java/org/apache/seata/spring/remoting/parser/RemotingFactoryBeanParserTest.java:112
- Instead of only asserting
resultis not null, consider asserting that the returned object exactly matches the expectedfactoryBean(e.g., usingassertSameorassertEquals) to verify correct wiring.
Assertions.assertNotNull(result);
spring/src/test/java/org/apache/seata/spring/remoting/parser/RemotingFactoryBeanParserTest.java:209
- To fully validate
getProtocol(), mockdefaultRemotingParser.getProtocol()to return a non-default value and assert thatremotingFactoryBeanParser.getProtocol()returns that value.
Assertions.assertEquals(0, result);
spring/pom.xml:67
- [nitpick] The
seata-sqlparser-druiddependency doesn’t appear to be used by these tests; consider removing it or documenting its purpose to prevent unused bloat in the module.
<artifactId>seata-sqlparser-druid</artifactId>
spring/src/test/java/org/apache/seata/spring/remoting/parser/RemotingFactoryBeanParserTest.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7420 +/- ##
============================================
+ Coverage 58.55% 58.60% +0.04%
Complexity 571 571
============================================
Files 1269 1269
Lines 45730 45730
Branches 5548 5548
============================================
+ Hits 26778 26799 +21
+ Misses 16374 16350 -24
- Partials 2578 2581 +3 see 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
YongGoose
reviewed
Jun 7, 2025
Member
YongGoose
left a comment
YongGoose
left a comment
There was a problem hiding this comment.
Looks good.
left some comments
Comment on lines
87
to
89
| TestService testService = new TestServiceImpl(); | ||
| ProxyFactory proxyFactory = new ProxyFactory(testService); | ||
| TestService proxyTestService = (TestService) proxyFactory.getProxy(); |
Member
There was a problem hiding this comment.
What do you think about extracting this into a separate method?
|
|
||
| // Test | ||
| Object result = remotingFactoryBeanParser.getRemotingFactoryBean(proxyTestService, "testService"); | ||
| Assertions.assertNotNull(result); |
Member
There was a problem hiding this comment.
Is there another way to do this without using notNull?
Contributor
Author
|
Please let me know if there is anything else that needs to be changed |
slievrly
reviewed
Jun 10, 2025
changes/en-us/2.x.md
Outdated
| - [[#7205](https://github.com/apache/incubator-seata/issues/7205)] add UT for namingserver module | ||
| - [[#7359](https://github.com/apache/incubator-seata/issues/7359)] merge submodule test reports | ||
| - [[#7377](https://github.com/apache/incubator-seata/issues/7377)] add UT for org.apache.seata.spring.annotation.scannercheckers | ||
| - [[#7378](https://github.com/apache/incubator-seata/issues/7378)] add UT for RemotingFactoryBeanParser class |
Contributor
Author
There was a problem hiding this comment.
Sorry, I have corrected my previous commit to 2.x md
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7378
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews