Skip to content

Conversation

@YongGoose
Copy link
Member

@YongGoose YongGoose commented Apr 29, 2025

  • I have registered the PR changes.

There was an issue where Tomcat 9.0.99 could not be started with JDK 17.
As a result, the test run with JDK 17 in the CI for the PR below failed.
image
image

According to the documentation linked below, this issue has been resolved in version 9.0.100, so I upgrade the version to 9.0.100.

@YongGoose YongGoose changed the title optimize: upgrade tomcat to 1.4.21 optimize: upgrade tomcat to 9.0.100 Apr 29, 2025
@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.50%. Comparing base (8c72b89) to head (6ba76b0).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7329      +/-   ##
============================================
- Coverage     54.52%   54.50%   -0.02%     
+ Complexity     7303     7300       -3     
============================================
  Files          1178     1178              
  Lines         41962    41962              
  Branches       4923     4923              
============================================
- Hits          22878    22871       -7     
- Misses        16914    16925      +11     
+ Partials       2170     2166       -4     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@funky-eyes funky-eyes added this to the 2.5.0 milestone Apr 30, 2025
@funky-eyes funky-eyes added type: optimize dependencies Pull requests that update a dependency file labels Apr 30, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit a84b7be into apache:2.x Apr 30, 2025
9 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type: optimize

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants