test: improved test SqlServerInsertRecognizerTest #7294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7294 +/- ##
============================================
- Coverage 54.49% 54.49% -0.01%
Complexity 7301 7301
============================================
Files 1178 1178
Lines 41962 41962
Branches 4923 4923
============================================
- Hits 22869 22867 -2
- Misses 16925 16927 +2
Partials 2168 2168 see 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
slievrly
changed the title
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Summary:
Elaboration:
getSQLStatement, creating recognizer) were repeated multiple times with different inputs, making the test harder to maintain and extend.To accomplish this, I separated the 2 logics into different test and then retrofitted the explicit values test into a parameterized unit test. This reduces duplication, allows easy extension by simply adding new value sets, and makes debugging easier as it clearly indicates which test failed instead of requiring a search through individual assertions. The separated tests also increase the fault detection capabilities of the suit.
Test execution results after changes:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Successful tests run
Ⅴ. Special notes for reviews